groovy-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GROOVY-8908) Bump gradle to 5.0
Date Mon, 03 Dec 2018 16:44:00 GMT

    [ https://issues.apache.org/jira/browse/GROOVY-8908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16707503#comment-16707503
] 

ASF GitHub Bot commented on GROOVY-8908:
----------------------------------------

Github user melix commented on a diff in the pull request:

    https://github.com/apache/groovy/pull/835#discussion_r238345659
  
    --- Diff: subprojects/parser-antlr4/build.gradle ---
    @@ -30,9 +30,11 @@ def srcBase = "subprojects/parser-antlr4/src"
     def srcMain = "$srcBase/main"
     def srcTest = "$srcBase/test"
     
    -final PARSER_PACKAGE_NAME = 'org.apache.groovy.parser.antlr4'
     generateGrammarSource {
    +    maxHeapSize = '1g'
    --- End diff --
    
    From my tests it seems we can reduce to `512m`, otherwise LGTM :+1: 


> Bump gradle to 5.0
> ------------------
>
>                 Key: GROOVY-8908
>                 URL: https://issues.apache.org/jira/browse/GROOVY-8908
>             Project: Groovy
>          Issue Type: Dependency upgrade
>            Reporter: Daniel Sun
>            Assignee: Daniel Sun
>            Priority: Major
>             Fix For: 3.0.0-alpha-4
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message