groovy-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "paolo di tommaso (JIRA)" <j...@apache.org>
Subject [jira] [Closed] (GROOVY-7371) AST xform @Slf4j does not check level guard
Date Wed, 26 Dec 2018 10:56:00 GMT

     [ https://issues.apache.org/jira/browse/GROOVY-7371?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

paolo di tommaso closed GROOVY-7371.
------------------------------------
    Resolution: Invalid

> AST xform @Slf4j does not check level guard
> -------------------------------------------
>
>                 Key: GROOVY-7371
>                 URL: https://issues.apache.org/jira/browse/GROOVY-7371
>             Project: Groovy
>          Issue Type: Bug
>    Affects Versions: 2.3.11
>            Reporter: paolo di tommaso
>            Priority: Minor
>
> Groovy logging AST transformation is supposed to  "wrap all calls to log.level() into
the appropriate log.isLevelEnabled guard, depending on the underlying framework " 
> http://groovy-lang.org/metaprogramming.html#_logging_improvements
> However the following test fails: 
> {code}
> @groovy.util.logging.Slf4j 
> class TestLog {
>   def bar () {
>     int count=0
>     if( log.isTraceEnabled() )  {
>         log.trace "${count++}"
>     }
>     return count
>   }
>   def foo () {
>     int count=0
>     log.trace "${count++}"
>     return count
>   }
> }
> assert new TestLog().bar() == 0
> assert new TestLog().foo() == 0 
> Assertion failed: 
> assert new TestLog().foo() == 0
>        |             |     |
>        |             1     false
>        TestLog@416b8a53
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message