groovy-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From danielsun1106 <...@git.apache.org>
Subject [GitHub] groovy pull request #837: GROOVY-8917: Failed to infer parameter type of som...
Date Tue, 11 Dec 2018 01:34:31 GMT
Github user danielsun1106 commented on a diff in the pull request:

    https://github.com/apache/groovy/pull/837#discussion_r240445739
  
    --- Diff: src/main/java/org/codehaus/groovy/classgen/asm/util/TypeUtil.java ---
    @@ -213,4 +220,15 @@ private static String makeRefDescription(String name) {
             long.class, Long.class,
             short.class, Short.class
         );
    +
    +    private static final Map<ClassNode, ClassNode> PRIMITIVE_CLASSNODE_TO_WRAPPED_CLASSNODE_MAP
= Maps.of(
    +            ClassHelper.byte_TYPE, ClassHelper.Byte_TYPE,
    +            ClassHelper.boolean_TYPE, ClassHelper.Boolean_TYPE,
    +            ClassHelper.char_TYPE, ClassHelper.Character_TYPE,
    +            ClassHelper.double_TYPE, ClassHelper.Double_TYPE,
    +            ClassHelper.float_TYPE, ClassHelper.Float_TYPE,
    +            ClassHelper.int_TYPE, ClassHelper.Integer_TYPE,
    +            ClassHelper.long_TYPE, ClassHelper.Long_TYPE,
    +            ClassHelper.short_TYPE, ClassHelper.Short_TYPE
    +    );
    --- End diff --
    
    @paulk-asert As we can see, the existing type mapping is Class to Class,  but we need
map ClassNode to ClassNode. Though we can convert ClassNode to Class and get the mapping result
then convert the result to ClassNode, it is less efficient.
    
    https://github.com/apache/groovy/blob/9cea59b95367c1d563e719ebeddcdecb58199750/src/main/java/org/codehaus/groovy/classgen/asm/util/TypeUtil.java#L213


---

Mime
View raw message