From notifications-return-13453-archive-asf-public=cust-asf.ponee.io@groovy.apache.org Fri Aug 3 18:21:04 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id DCE00180647 for ; Fri, 3 Aug 2018 18:21:03 +0200 (CEST) Received: (qmail 29664 invoked by uid 500); 3 Aug 2018 16:21:03 -0000 Mailing-List: contact notifications-help@groovy.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@groovy.apache.org Delivered-To: mailing list notifications@groovy.apache.org Received: (qmail 29655 invoked by uid 99); 3 Aug 2018 16:21:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 03 Aug 2018 16:21:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 928ACC1D14 for ; Fri, 3 Aug 2018 16:21:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -110.301 X-Spam-Level: X-Spam-Status: No, score=-110.301 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id tGymTiaRawJJ for ; Fri, 3 Aug 2018 16:21:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 359215F27E for ; Fri, 3 Aug 2018 16:21:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 75B17E2072 for ; Fri, 3 Aug 2018 16:21:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 26AAC27756 for ; Fri, 3 Aug 2018 16:21:00 +0000 (UTC) Date: Fri, 3 Aug 2018 16:21:00 +0000 (UTC) From: "Eric Milles (JIRA)" To: notifications@groovy.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (GROOVY-8726) Parameter lacks a reference to the MethodNode it belongs to MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/GROOVY-8726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16568431#comment-16568431 ] Eric Milles commented on GROOVY-8726: ------------------------------------- When creating a clone of any node, be sure that you transfer annotations, node metadata and source position. Here is a more complete clone for Parameter: {code:java} parameter = new Parameter(parameterType, original.getName(), original.getInitialExpression()); parameter.addAnnotations(original.getAnnotations()); parameter.setClosureSharedVariable(original.isClosureSharedVariable()); parameter.setDeclaringClass(original.getDeclaringClass()); // TODO: resolve? parameter.setHasNoRealSourcePosition(original.hasNoRealSourcePosition()); parameter.setInStaticContext(original.isInStaticContext()); parameter.setModifiers(original.getModifiers()); parameter.copyNodeMetaData(original); parameter.setOriginType(original.getOriginType()); parameter.setSourcePosition(original); parameter.setSynthetic(original.isSynthetic()); {code} > Parameter lacks a reference to the MethodNode it belongs to > ----------------------------------------------------------- > > Key: GROOVY-8726 > URL: https://issues.apache.org/jira/browse/GROOVY-8726 > Project: Groovy > Issue Type: Improvement > Components: Compiler > Affects Versions: 2.5.1 > Reporter: James Kleeh > Priority: Major > > The Parameter class lacks a reference to it's method node. This is important to find arguments that have been "overridden". -- This message was sent by Atlassian JIRA (v7.6.3#76005)