From notifications-return-13438-archive-asf-public=cust-asf.ponee.io@groovy.apache.org Thu Aug 2 09:06:06 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id B29FF180674 for ; Thu, 2 Aug 2018 09:06:05 +0200 (CEST) Received: (qmail 99794 invoked by uid 500); 2 Aug 2018 07:06:04 -0000 Mailing-List: contact notifications-help@groovy.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@groovy.apache.org Delivered-To: mailing list notifications@groovy.apache.org Received: (qmail 99785 invoked by uid 99); 2 Aug 2018 07:06:04 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 02 Aug 2018 07:06:04 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 5599818082C for ; Thu, 2 Aug 2018 07:06:04 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.501 X-Spam-Level: X-Spam-Status: No, score=-109.501 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id 4NavgJNuTMOj for ; Thu, 2 Aug 2018 07:06:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 7AB6A5F27B for ; Thu, 2 Aug 2018 07:06:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id A06B7E0177 for ; Thu, 2 Aug 2018 07:06:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 1A34227752 for ; Thu, 2 Aug 2018 07:06:00 +0000 (UTC) Date: Thu, 2 Aug 2018 07:06:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: notifications@groovy.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (GROOVY-8726) Parameter lacks a reference to the MethodNode it belongs to MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/GROOVY-8726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16566430#comment-16566430 ] ASF GitHub Bot commented on GROOVY-8726: ---------------------------------------- GitHub user jameskleeh opened a pull request: https://github.com/apache/groovy/pull/779 GROOVY-8726: Store the method node reference in Parameter This implementation copies all parameters when they are passed to the method node constructor. While there will be some waste in this process, I find it much easier and maintainable compared to changing all of the places in the codebase where parameters are reused. Note that the build on my fork is failing with an unrelated compilation error You can merge this pull request into a Git repository by running: $ git pull https://github.com/jameskleeh/groovy master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/groovy/pull/779.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #779 ---- commit 6710d938b557dbf709924d3112d84c8de8e97a99 Author: jameskleeh Date: 2018-08-02T04:03:41Z GROOVY-8726: Store the method node reference in Parameter ---- > Parameter lacks a reference to the MethodNode it belongs to > ----------------------------------------------------------- > > Key: GROOVY-8726 > URL: https://issues.apache.org/jira/browse/GROOVY-8726 > Project: Groovy > Issue Type: Improvement > Components: Compiler > Affects Versions: 2.5.1 > Reporter: James Kleeh > Priority: Major > > The Parameter class lacks a reference to it's method node. This is important to find arguments that have been "overridden". -- This message was sent by Atlassian JIRA (v7.6.3#76005)