From notifications-return-13628-archive-asf-public=cust-asf.ponee.io@groovy.apache.org Thu Aug 16 08:32:04 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 01E8E18067A for ; Thu, 16 Aug 2018 08:32:03 +0200 (CEST) Received: (qmail 91272 invoked by uid 500); 16 Aug 2018 06:32:02 -0000 Mailing-List: contact notifications-help@groovy.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@groovy.apache.org Delivered-To: mailing list notifications@groovy.apache.org Received: (qmail 91262 invoked by uid 99); 16 Aug 2018 06:32:02 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 16 Aug 2018 06:32:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 532B1C77EC for ; Thu, 16 Aug 2018 06:32:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.501 X-Spam-Level: X-Spam-Status: No, score=-109.501 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id atrVBAMd3Wbi for ; Thu, 16 Aug 2018 06:32:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 4852E5F396 for ; Thu, 16 Aug 2018 06:32:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 9F7ACE0A31 for ; Thu, 16 Aug 2018 06:32:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 40B4824693 for ; Thu, 16 Aug 2018 06:32:00 +0000 (UTC) Date: Thu, 16 Aug 2018 06:32:00 +0000 (UTC) From: "Paul King (JIRA)" To: notifications@groovy.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (GROOVY-8669) Groovy class does not compile if the ValueType of an annotation is not on the classpath MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/GROOVY-8669?page=3Dcom.atlassi= an.jira.plugin.system.issuetabpanels:all-tabpanel ] Paul King updated GROOVY-8669: ------------------------------ Description:=20 If a groovy class (Test.groovy) references a class (AnnotatedClass) which h= as an annotation (Annotation) with a value class (ValueClass), which is not= on the classpath an NoClassDefFoundError is thrown. This does happen during Compilation. This did not happen in Groovy 2.4.15. The stacktrace is: {noformat} Caused by: java.lang.NoClassDefFoundError: annos.ValueClass =C2=A0=C2=A0 =C2=A0at org.codehaus.groovy.ast.decompiled.AsmReferenceResolv= er.resolveClass(AsmReferenceResolver.java:48) =C2=A0=C2=A0 =C2=A0at org.codehaus.groovy.ast.decompiled.AsmReferenceResolv= er.resolveNonArrayType(AsmReferenceResolver.java:81) =C2=A0=C2=A0 =C2=A0at org.codehaus.groovy.ast.decompiled.AsmReferenceResolv= er.resolveType(AsmReferenceResolver.java:72) =C2=A0=C2=A0 =C2=A0at org.codehaus.groovy.ast.decompiled.Annotations.annota= tionValueToExpression(Annotations.java:58) =C2=A0=C2=A0 =C2=A0at org.codehaus.groovy.ast.decompiled.Annotations.create= AnnotationNode(Annotations.java:51) ... {noformat} I think the class org.codehaus.groovy.ast.decompiled.Annotations should als= o ignore annotation nodes, if the values type is not resolvable. Like it is= done if the annotation type itself is not resolvable, see line 43-46. I have attached a simple sample to reproduce the issue. 1. Compile it with gradle build 2. Open the jar file annos/build/libs/annos.jar 3. Delete the classfile annos/ValueClass.class 4. Compile it with gradle :client:build Now the exception is thrown. =C2=A0 =C2=A0 =C2=A0 was: If a groovy class (Test.groovy) references a class (AnnotatedClass) which h= as an annotation (Annotation) with a value class (ValueClass), which is not= on the classpath an NoClassDefFoundError is thrown. {{This does happen during Compilation. This did not happen in Groovy 2.4.15= .}} {{The stacktrace is:}} {{Caused by: java.lang.NoClassDefFoundError: annos.ValueClass}} {{=C2=A0=C2=A0 =C2=A0at org.codehaus.groovy.ast.decompiled.AsmReferenceRes= olver.resolveClass(AsmReferenceResolver.java:48)}} {{=C2=A0=C2=A0 =C2=A0at org.codehaus.groovy.ast.decompiled.AsmReferenceRes= olver.resolveNonArrayType(AsmReferenceResolver.java:81)}} {{=C2=A0=C2=A0 =C2=A0at org.codehaus.groovy.ast.decompiled.AsmReferenceRes= olver.resolveType(AsmReferenceResolver.java:72)}} {{=C2=A0=C2=A0 =C2=A0at org.codehaus.groovy.ast.decompiled.Annotations.ann= otationValueToExpression(Annotations.java:58)}} {{=C2=A0=C2=A0 =C2=A0at org.codehaus.groovy.ast.decompiled.Annotations.cre= ateAnnotationNode(Annotations.java:51)}} \{{=C2=A0=C2=A0 =C2=A0at }} I think the class org.codehaus.groovy.ast.decompiled.Annotations should als= o ignore annotation nodes, if the values type is not resolvable. Like it is= done if the annotation type itself is not resolvable, see line 43-46. I have attached a simple sample to reproduce the issue. 1. Compile it with gradle build 2. Open the jar file annos/build/libs/annos.jar 3. Delete the classfile annos/ValueClass.class 4. Compile it with gradle :client:build Now the exception is thrown. =C2=A0 =C2=A0 =C2=A0 > Groovy class does not compile if the ValueType of an annotation is not on= the classpath > -------------------------------------------------------------------------= -------------- > > Key: GROOVY-8669 > URL: https://issues.apache.org/jira/browse/GROOVY-8669 > Project: Groovy > Issue Type: Bug > Components: class generator > Affects Versions: 2.5.0 > Reporter: Andreas Turban > Priority: Major > Labels: annotations, compile-error > Attachments: AnnoTest.zip > > > If a groovy class (Test.groovy) references a class (AnnotatedClass) which= has an annotation (Annotation) with a value class (ValueClass), which is n= ot on the classpath an NoClassDefFoundError is thrown. > This does happen during Compilation. This did not happen in Groovy 2.4.15= . > The stacktrace is: > {noformat} > Caused by: java.lang.NoClassDefFoundError: annos.ValueClass > =C2=A0=C2=A0 =C2=A0at org.codehaus.groovy.ast.decompiled.AsmReferenceReso= lver.resolveClass(AsmReferenceResolver.java:48) > =C2=A0=C2=A0 =C2=A0at org.codehaus.groovy.ast.decompiled.AsmReferenceReso= lver.resolveNonArrayType(AsmReferenceResolver.java:81) > =C2=A0=C2=A0 =C2=A0at org.codehaus.groovy.ast.decompiled.AsmReferenceReso= lver.resolveType(AsmReferenceResolver.java:72) > =C2=A0=C2=A0 =C2=A0at org.codehaus.groovy.ast.decompiled.Annotations.anno= tationValueToExpression(Annotations.java:58) > =C2=A0=C2=A0 =C2=A0at org.codehaus.groovy.ast.decompiled.Annotations.crea= teAnnotationNode(Annotations.java:51) > ... > {noformat} > I think the class org.codehaus.groovy.ast.decompiled.Annotations should a= lso ignore annotation nodes, if the values type is not resolvable. Like it = is done if the annotation type itself is not resolvable, see line 43-46. > I have attached a simple sample to reproduce the issue. > 1. Compile it with gradle build > 2. Open the jar file annos/build/libs/annos.jar > 3. Delete the classfile annos/ValueClass.class > 4. Compile it with gradle :client:build > Now the exception is thrown. > =C2=A0 > =C2=A0 > =C2=A0 -- This message was sent by Atlassian JIRA (v7.6.3#76005)