groovy-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Eric Milles (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GROOVY-8728) Verifier.addDefaultParameters erases metadata if run more than once
Date Mon, 06 Aug 2018 14:18:00 GMT

    [ https://issues.apache.org/jira/browse/GROOVY-8728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16570256#comment-16570256
] 

Eric Milles commented on GROOVY-8728:
-------------------------------------

Yes, I had a simple closure with a default value for a param.


def closure = { one, two = 2 ->

}

>From there, I'm not sure if it would be unset within an AST transform, but it was unset
when visiting the AST in eclipse for purposes of semantic highlighting of the source.



> Verifier.addDefaultParameters erases metadata if run more than once
> -------------------------------------------------------------------
>
>                 Key: GROOVY-8728
>                 URL: https://issues.apache.org/jira/browse/GROOVY-8728
>             Project: Groovy
>          Issue Type: Bug
>    Affects Versions: 2.4.15, 2.5.1
>            Reporter: Eric Milles
>            Priority: Minor
>
> When processing sources with closure with parameter defaults, {{Verifier}} is wiping
out the node metadata that contains the initial value expression.  At the end of {{addDefaultParameters(DefaultArgsAction
action, MethodNode method)}}, there is a for loop:
> {code:java}
>         for (Parameter parameter : parameters) {
>             // GRECLIPSE add
>             if (!parameter.hasInitialExpression()) continue;
>             // GRECLIPSE end
>             // remove default expression and store it as node metadata
>             parameter.putNodeMetaData(Verifier.INITIAL_EXPRESSION, parameter.getInitialExpression());
>             parameter.setInitialExpression(null);
>         }
> {code}
> This loop currently moves the initial expression to node metadata.  However, when this
method runs a second time, it takes null from {{getInitialExpression}} and puts that as the
new metadata value, even if the node already has been processed.
> Adding a check {{hasInitialExpression}} solves this issue, making {{addDefaultParameters}}
idempotent.  This also prevent adding the metadata value in the first place for a parameter
that never had a default value expression.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message