groovy-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GROOVY-8726) Parameter lacks a reference to the MethodNode it belongs to
Date Thu, 02 Aug 2018 07:06:00 GMT

    [ https://issues.apache.org/jira/browse/GROOVY-8726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16566430#comment-16566430
] 

ASF GitHub Bot commented on GROOVY-8726:
----------------------------------------

GitHub user jameskleeh opened a pull request:

    https://github.com/apache/groovy/pull/779

    GROOVY-8726: Store the method node reference in Parameter

    This implementation copies all parameters when they are passed to the method node constructor.
While there will be some waste in this process, I find it much easier and maintainable compared
to changing all of the places in the codebase where parameters are reused.
    
    Note that the build on my fork is failing with an unrelated compilation error

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jameskleeh/groovy master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/groovy/pull/779.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #779
    
----
commit 6710d938b557dbf709924d3112d84c8de8e97a99
Author: jameskleeh <james.kleeh@...>
Date:   2018-08-02T04:03:41Z

    GROOVY-8726: Store the method node reference in Parameter

----


> Parameter lacks a reference to the MethodNode it belongs to
> -----------------------------------------------------------
>
>                 Key: GROOVY-8726
>                 URL: https://issues.apache.org/jira/browse/GROOVY-8726
>             Project: Groovy
>          Issue Type: Improvement
>          Components: Compiler
>    Affects Versions: 2.5.1
>            Reporter: James Kleeh
>            Priority: Major
>
> The Parameter class lacks a reference to it's method node. This is important to find
arguments that have been "overridden".



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message