groovy-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Paul King (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (GROOVY-8695) @Delegate does not compile deterministically
Date Tue, 24 Jul 2018 22:32:00 GMT

    [ https://issues.apache.org/jira/browse/GROOVY-8695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16554860#comment-16554860
] 

Paul King edited comment on GROOVY-8695 at 7/24/18 10:31 PM:
-------------------------------------------------------------

Just so I am clear, when you say "partial" do you mean partially for or partially against?
If it's just methods that are impacted, I think we'd need to do sorting not just for @Delegate
but quite a few of the transforms and for traits too. If it impacts fields as well, then there
would be more transforms impacted. We could lazily sort having a utils method to call for
all transforms that needed it but since ClassNode isn't immutable, it might be difficult to
detect when it changed unless you baked it into the class.


was (Author: paulk):
Just so I am clear, when you say "partial" do you mean partially for or partially against?
If it's just methods that are impacted, I think we'd need to do sorting not just for @Delegate
but quite a few of the transforms and for traits too. If it impacts fields as well, then there
would be more transforms affected.

> @Delegate does not compile deterministically
> --------------------------------------------
>
>                 Key: GROOVY-8695
>                 URL: https://issues.apache.org/jira/browse/GROOVY-8695
>             Project: Groovy
>          Issue Type: Bug
>    Affects Versions: 2.4.12
>            Reporter: Luke Daley
>            Priority: Major
>         Attachments: ConcurrentSpecification-with-groovy-2.4.15.zip, ConcurrentSpecification.class,
ConcurrentSpecification.class
>
>
> Checkout gradle/gradle from Github, run:
> ```
> ./gradlew core:cleanCompileTestFixturesGroovy core:compileTestFixturesGroovy --no-build-cache
&& md5 subprojects/core/build/classes/groovy/testFixtures/org/gradle/util/ConcurrentSpecification.class
> ```
> This class is super thin: [https://github.com/gradle/gradle/blob/a1b9612fa06f90f20b115cede557e22287501034/subprojects/core/src/testFixtures/groovy/org/gradle/util/ConcurrentSpecification.groovy#L23]
>  
> Guess is that it is `@Delegate` or `@Delegate` in conjunction with Spock
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message