groovy-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jochen Theodorou (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GROOVY-8695) @Delegate does not compile deterministically
Date Tue, 24 Jul 2018 20:50:00 GMT

    [ https://issues.apache.org/jira/browse/GROOVY-8695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16554780#comment-16554780
] 

Jochen Theodorou commented on GROOVY-8695:
------------------------------------------

LinkedHashMap helps only if the insertion order is stable between runs... something you can
accomplish only if you specify a sorting. If you get random elements from the ClassNode because
of reflection, then just a LinkedHashMap will not help.

At the same time I am partial on sorting the methods in ClassNode. It is additional overhead
we do not need in most cases, so it will slow down the compiler

> @Delegate does not compile deterministically
> --------------------------------------------
>
>                 Key: GROOVY-8695
>                 URL: https://issues.apache.org/jira/browse/GROOVY-8695
>             Project: Groovy
>          Issue Type: Bug
>    Affects Versions: 2.4.12
>            Reporter: Luke Daley
>            Priority: Major
>         Attachments: ConcurrentSpecification-with-groovy-2.4.15.zip, ConcurrentSpecification.class,
ConcurrentSpecification.class
>
>
> Checkout gradle/gradle from Github, run:
> ```
> ./gradlew core:cleanCompileTestFixturesGroovy core:compileTestFixturesGroovy --no-build-cache
&& md5 subprojects/core/build/classes/groovy/testFixtures/org/gradle/util/ConcurrentSpecification.class
> ```
> This class is super thin: [https://github.com/gradle/gradle/blob/a1b9612fa06f90f20b115cede557e22287501034/subprojects/core/src/testFixtures/groovy/org/gradle/util/ConcurrentSpecification.groovy#L23]
>  
> Guess is that it is `@Delegate` or `@Delegate` in conjunction with Spock
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message