groovy-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Paul King (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (GROOVY-8688) AsmDecompiler.parseClass fails against a Java 11 JEP 181 class
Date Fri, 06 Jul 2018 11:58:00 GMT

    [ https://issues.apache.org/jira/browse/GROOVY-8688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16534684#comment-16534684
] 

Paul King edited comment on GROOVY-8688 at 7/6/18 11:57 AM:
------------------------------------------------------------

Thanks for the PR. I've noticed the parseClass failure on JDK11 too recently and was going
to explore something similar. I was hoping to wait until ASM7 was non experimental but with
JDK versions moving so quickly, I don't think we have that luxury.

P.S. You should be able to use the "install" task to publish to the local maven repo since
we already apply the maven plugin in upload.gradle.


was (Author: paulk):
Thanks for the PR. I've noticed the parseClass failure on JDK11 too recently and was going
to explore something similar. I was hoping to wait until ASM7 was non experimental but with
JDK versions moving so quickly, I don't think we have that luxury.

P.S. You should be able to use the "install" task to publish to the local maven repo.

> AsmDecompiler.parseClass fails against a Java 11 JEP 181 class
> --------------------------------------------------------------
>
>                 Key: GROOVY-8688
>                 URL: https://issues.apache.org/jira/browse/GROOVY-8688
>             Project: Groovy
>          Issue Type: Bug
>          Components: bytecode
>    Affects Versions: 2.5.0
>            Reporter: Robert Stupp
>            Priority: Major
>
> If {{AsmDecompiler.parseClass}} is invoked on Java 11 for a class that already uses [nest-based
access control|http://openjdk.java.net/jeps/181], parsing with asm (on master) will fail with
an {{UnsupportedOperationException}} in {{org.objectweb.asm.ClassVisitor#visitNestMemberExperimental}}
or {{visitNestHostExperimental}}.
> A trivial fix is to bump {{org.codehaus.groovy.control.CompilerConfiguration#ASM_API_VERSION}}
to {{ASM7_EXPERIMENTAL}} with asm 6.2.
> For the 2.5.x-branch, an upgrade from asm 6.1.1 to 6.2 is necessary.
>  
> [PR for GROOVY_2_5_x branch|https://github.com/apache/groovy/pull/768]
> [PR for master branch|https://github.com/apache/groovy/pull/769]
> {{./gradlew test}} is clean for both branches.
>  
> Side note: I've added the maven plugin to allow deployment of the artifacts into the
local maven repo. I suspect, it should to removed from the PRs?



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message