From notifications-return-12189-archive-asf-public=cust-asf.ponee.io@groovy.apache.org Fri May 11 16:46:10 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 726C8180647 for ; Fri, 11 May 2018 16:46:09 +0200 (CEST) Received: (qmail 14480 invoked by uid 500); 11 May 2018 14:46:08 -0000 Mailing-List: contact notifications-help@groovy.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@groovy.apache.org Delivered-To: mailing list notifications@groovy.apache.org Received: (qmail 14471 invoked by uid 99); 11 May 2018 14:46:08 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 11 May 2018 14:46:08 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 363431A23C0 for ; Fri, 11 May 2018 14:46:08 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -102.31 X-Spam-Level: X-Spam-Status: No, score=-102.31 tagged_above=-999 required=6.31 tests=[RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, URIBL_BLOCKED=0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id c21fyqRBnRTd for ; Fri, 11 May 2018 14:46:07 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 5F3365F178 for ; Fri, 11 May 2018 14:46:07 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 44688E0FAB for ; Fri, 11 May 2018 14:46:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 83F7B2155B for ; Fri, 11 May 2018 14:46:00 +0000 (UTC) Date: Fri, 11 May 2018 14:46:00 +0000 (UTC) From: "Daniel Sun (JIRA)" To: notifications@groovy.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Resolved] (GROOVY-8212) coerce GString to String when used as Map key MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/GROOVY-8212?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Sun resolved GROOVY-8212. -------------------------------- Resolution: Fixed Assignee: Daniel Sun It is fixed: https://github.com/apache/groovy/commit/5f6689638160c44dccbf2b7155d35edff2389979 > coerce GString to String when used as Map key > --------------------------------------------- > > Key: GROOVY-8212 > URL: https://issues.apache.org/jira/browse/GROOVY-8212 > Project: Groovy > Issue Type: Bug > Components: Static compilation, Static Type Checker > Affects Versions: 2.4.10 > Reporter: Christopher Smith > Assignee: Daniel Sun > Priority: Minor > > When a GString is used as the key for a bracket-style map get (in this case, from an overly verbose CSV file): > {code} > row["$param URL"] > {code} > the {{GStringImpl}} object is passed directly to {{Map#get(Object)}}. Since GStrings are never equal to Strings, this means that the get will always return null. > If {{row}} is explicitly declared as a {{Map}}, however, Groovy ought to identify the intended behavior (using a templated string as a map key) and use the string value instead. > The current behavior is a problem because even in static compilation mode, where the generic key bound is known, Groovy does not complain about the use of a GString here (because it normally treats GStrings as valid for {{String}} targets?), but the lookup will fail at runtime. -- This message was sent by Atlassian JIRA (v7.6.3#76005)