From notifications-return-11986-archive-asf-public=cust-asf.ponee.io@groovy.apache.org Thu Apr 26 23:30:04 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 84B3E180648 for ; Thu, 26 Apr 2018 23:30:03 +0200 (CEST) Received: (qmail 70292 invoked by uid 500); 26 Apr 2018 21:30:02 -0000 Mailing-List: contact notifications-help@groovy.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@groovy.apache.org Delivered-To: mailing list notifications@groovy.apache.org Received: (qmail 70283 invoked by uid 99); 26 Apr 2018 21:30:02 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 26 Apr 2018 21:30:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 271ABCA070 for ; Thu, 26 Apr 2018 21:30:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.501 X-Spam-Level: X-Spam-Status: No, score=-109.501 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id iUKmcMCS4mnA for ; Thu, 26 Apr 2018 21:30:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 1BE445F11F for ; Thu, 26 Apr 2018 21:30:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 93842E0CB0 for ; Thu, 26 Apr 2018 21:30:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 3D50C20EB9 for ; Thu, 26 Apr 2018 21:30:00 +0000 (UTC) Date: Thu, 26 Apr 2018 21:30:00 +0000 (UTC) From: "Remko Popma (JIRA)" To: notifications@groovy.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (GROOVY-8557) Verify that CliBuilder-based applications work correctly with picocli version of CliBuilder MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/GROOVY-8557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16454898#comment-16454898 ] Remko Popma commented on GROOVY-8557: ------------------------------------- One incompatibility still exists: groovydoc.Main, shell.Main and Console.groovy all define the {{classpath}} option twice: {code} def cli = new CliBuilder(usage : 'groovydoc [options] [packagenames] [sourcefiles]', writer: io.out, posix:false) ... cli.classpath(messages['cli.option.classpath.description']) // <1> cli.cp(longOpt: 'classpath', messages['cli.option.cp.description']) // <2> ... {code} I assume the above code was to support both a {{\-classpath <1>}} and a {{--classpath <2>}} option. I am surprised by this, because the commons-cli DefaultParser already accepts long options with both one and two preceding hyphens. (See {{CliBuilderTest.testMixedBurstingAndLongOptions}}.) In fact, to simulate commons-cli's behaviour, {{groovy.cli.picocli.CliBuilder}} implicitly registers all long options twice: once with one and once with two preceding hyphens. Unfortunately, because of this, with the picocli version of CliBuilder the above code gives the following error: {code} picocli.CommandLine$DuplicateOptionAnnotationsException: Option name '-classpath' is used by both option --classpath and option -classpath {code} So, some change is needed to migrate groovydoc.Main, shell.Main and Console.groovy to the picocli version of CliBuilder. Should we: # modify groovydoc.Main, shell.Main and Console.groovy to only add the {{\-cp/--classpath <2>}} option (and let CliBuilder take care of registering the long option with both one and two hypens in the underlying parser), or # modify the picocli version of CliBuilder to ensure that long options are registered only once in the underlying parser (perhaps with a flag to switch this on/off)? Then the application can register {{classpath}} with both one and two hyphens, if this is desirable. > Verify that CliBuilder-based applications work correctly with picocli version of CliBuilder > ------------------------------------------------------------------------------------------- > > Key: GROOVY-8557 > URL: https://issues.apache.org/jira/browse/GROOVY-8557 > Project: Groovy > Issue Type: Task > Components: command line processing > Reporter: Remko Popma > Priority: Major > > Follow-up task for GROOVY-8520. The following applications depend on CliBuilder: > * groovy-console_main/groovy.ui.Console.groovy > * groovy-docgenerator_main/org.codehaus.groovy.tools.DocGenerator.groovy > * groovy-groovydoc_main/org.codehaus.groovy.tools.groovydoc.Main.groovy > * groovy-groovysh_main/org.codehaus.groovy.tools.shell.Main.groovy (uses custom HelpFormatter) > This task is to verify that the above applications work correctly with the picocli version of CliBuilder. -- This message was sent by Atlassian JIRA (v7.6.3#76005)