From notifications-return-11836-archive-asf-public=cust-asf.ponee.io@groovy.apache.org Mon Apr 16 03:40:04 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 9F77A180648 for ; Mon, 16 Apr 2018 03:40:03 +0200 (CEST) Received: (qmail 26061 invoked by uid 500); 16 Apr 2018 01:40:02 -0000 Mailing-List: contact notifications-help@groovy.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@groovy.apache.org Delivered-To: mailing list notifications@groovy.apache.org Received: (qmail 26052 invoked by uid 99); 16 Apr 2018 01:40:02 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 16 Apr 2018 01:40:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 3884C180518 for ; Mon, 16 Apr 2018 01:40:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.511 X-Spam-Level: X-Spam-Status: No, score=-109.511 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id Go3pBvdvT-6D for ; Mon, 16 Apr 2018 01:40:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id E6B705FAC8 for ; Mon, 16 Apr 2018 01:40:00 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 6158BE0361 for ; Mon, 16 Apr 2018 01:40:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 0D0E121209 for ; Mon, 16 Apr 2018 01:40:00 +0000 (UTC) Date: Mon, 16 Apr 2018 01:40:00 +0000 (UTC) From: "Daniel Sun (JIRA)" To: notifications@groovy.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (GROOVY-8546) Parrot Parser: multiple Reader instances opened from SourceUnit; many left open MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/GROOVY-8546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16438915#comment-16438915 ] Daniel Sun commented on GROOVY-8546: ------------------------------------ {{CharStream}} of antlr4 is not a IO stream, so we need not close it. > Parrot Parser: multiple Reader instances opened from SourceUnit; many left open > ------------------------------------------------------------------------------- > > Key: GROOVY-8546 > URL: https://issues.apache.org/jira/browse/GROOVY-8546 > Project: Groovy > Issue Type: Bug > Components: parser > Affects Versions: 2.6.0-alpha-3, 3.0.0-alpha-2 > Reporter: Eric Milles > Priority: Major > > {{Antlr4ParserPlugin}} makes very inefficient use of {{ReaderSource}}/{{SourceUnit}}. {{parseCST}} is passed a {{Reader}} with the idea that it is the source of character data -- and this reader is closed from outside. It ignores this and mines the passed {{SourceUnit}}, which seems unnecessary since the same reference is passed again in {{buildAST}}. Both {{parseCST}} and {{buildAST}} call {{getReader}}, which opens a buffered reader on the source unit file and never closes them. Lastly, {{AstBuilder}} calls {{getReader}} as well to create a {{CharStream}} and never closes this reader. > Doing this in a long-running process (like an IDE) is causing numerous problems due to open file handles. > {code:java} > public class Antlr4ParserPlugin implements ParserPlugin { > private ReaderSource readerSource; > @Override > public Reduction parseCST(SourceUnit sourceUnit, java.io.Reader reader) throws CompilationFailedException { > try { > ReaderSource readerSource = sourceUnit.getSource(); > if (null != readerSource && null != readerSource.getReader()) { > this.readerSource = readerSource; > } else { > this.readerSource = new StringReaderSource(IOGroovyMethods.getText(reader), sourceUnit.getConfiguration()); > } > } catch (IOException e) { > throw new GroovyBugError("Failed to create StringReaderSource instance", e); > } > return null; > } > @Override > public ModuleNode buildAST(SourceUnit sourceUnit, ClassLoader classLoader, Reduction cst) throws ParserException { > try { > ReaderSource readerSource = sourceUnit.getSource(); > if (null == readerSource || null == readerSource.getReader()) { > sourceUnit.setSource(this.readerSource); > } > } catch (IOException e) { > sourceUnit.setSource(this.readerSource); > } > AstBuilder builder = new AstBuilder(sourceUnit); > return builder.buildAST(); > } > } > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)