groovy-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Arndt (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (GROOVY-8562) Wrong Closure delegation for property access when using @CompileStatic and DELEGATE_FIRST / DELEGATE_ONLY
Date Fri, 27 Apr 2018 15:18:00 GMT

     [ https://issues.apache.org/jira/browse/GROOVY-8562?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Michael Arndt updated GROOVY-8562:
----------------------------------
    Description: 
Closures resolve to owner property although `DELEGATE_FIRST` or `DELEGATE_ONLY` are set as
`resolveStrategy`.
 This only happens when `@CompileStatic` is used.
 This does not apply to method calls.
 For Groovy 2.3.11 this only affects read operations.

Only the versions 2.5.0-rc-1, 2.4.15, 2.3.11 have been tested yet.
 I will add tests for newer versions, but this requires a different test framework than Spock.

I have created a demo project at [https://github.com/MeneDev/groovy-bugreport-closure-strategy]

 
{code:java}
class ADelegate {
    def x = "delegate"
}

@CompileStatic
class AClass {
    public <T> T closureExecuter(
            ADelegate d,
            @DelegatesTo(value = ADelegate, strategy = DELEGATE_ONLY) Closure<T> c)
{
        c.resolveStrategy = DELEGATE_ONLY
        c.delegate = d
        return c()
    }

    def x = "owner"
    
    def test() {
        def theDelegate = new ADelegate()
        def res = closureExecuter(theDelegate) {
            return x
        }
        
        // is "owner" instead of "delegate"
        return res
    }
}
{code}

  was:
Closures resolve to owner property although `DELEGATE_FIRST`
or `DELEGATE_ONLY` are set as `resolveStrategy`.
This only happens when `@CompileStatic` is used.
This does not apply to method calls.
For Groovy 2.3.11 this only affects read operations.

Only the versions 2.5.0-rc-1, 2.4.15, 2.3.11 have been tested yet.
I will add tests for newer versions, but this requires a different
test framework than Spock.

I have created a demo project at [https://github.com/MeneDev/groovy-bugreport-closure-strategy]

 
{code:java}
class ADelegate {
    def x = "delegate"
}

@CompileStatic
class AClass {
    public <T> T closureExecuter(
            ADelegate d,
            @DelegatesTo(value = ADelegate, strategy = DELEGATE_ONLY) Closure<T> c)
{
        c.resolveStrategy = DELEGATE_ONLY
        c.delegate = d
        return c()
    }

    def x = "owner"
    
    def test() {
        def theDelegate = new ADelegate()
        def res = closureExecuter(theDelegate) {
            return x
        }
        
        // is "owner" instead of "delegate"
        return res
    }
}
{code}


> Wrong Closure delegation for property access when using @CompileStatic and DELEGATE_FIRST
/ DELEGATE_ONLY
> ---------------------------------------------------------------------------------------------------------
>
>                 Key: GROOVY-8562
>                 URL: https://issues.apache.org/jira/browse/GROOVY-8562
>             Project: Groovy
>          Issue Type: Bug
>          Components: Static compilation
>    Affects Versions: 2.3.11, 2.5.0-rc-1, 2.4.15
>            Reporter: Michael Arndt
>            Priority: Major
>
> Closures resolve to owner property although `DELEGATE_FIRST` or `DELEGATE_ONLY` are set
as `resolveStrategy`.
>  This only happens when `@CompileStatic` is used.
>  This does not apply to method calls.
>  For Groovy 2.3.11 this only affects read operations.
> Only the versions 2.5.0-rc-1, 2.4.15, 2.3.11 have been tested yet.
>  I will add tests for newer versions, but this requires a different test framework than
Spock.
> I have created a demo project at [https://github.com/MeneDev/groovy-bugreport-closure-strategy]
>  
> {code:java}
> class ADelegate {
>     def x = "delegate"
> }
> @CompileStatic
> class AClass {
>     public <T> T closureExecuter(
>             ADelegate d,
>             @DelegatesTo(value = ADelegate, strategy = DELEGATE_ONLY) Closure<T>
c) {
>         c.resolveStrategy = DELEGATE_ONLY
>         c.delegate = d
>         return c()
>     }
>     def x = "owner"
>     
>     def test() {
>         def theDelegate = new ADelegate()
>         def res = closureExecuter(theDelegate) {
>             return x
>         }
>         
>         // is "owner" instead of "delegate"
>         return res
>     }
> }
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message