groovy-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Paul King (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (GROOVY-8559) CLONE - Add @Repeatable java8 annotation support
Date Wed, 25 Apr 2018 11:59:00 GMT

     [ https://issues.apache.org/jira/browse/GROOVY-8559?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Paul King updated GROOVY-8559:
------------------------------
    Description: 
I cloned the issue to fix another case. For the case of pre-compiled Java annotations, a check
in {{ResolveVisitor#visitAnnotations}} is triggering an error prior to the auto-collecting
of annotations code being handled in {{ExtendedVerifier}}.


  was:
raised on stackoverflow: https://stackoverflow.com/questions/44532632/is-the-repeatable-annotation-not-supported-by-groovy/44628119#44628119

Problem: the following code in groovy 2.4.11 / java8

{code}
   @MyAnnotation(value = "val1")
   @MyAnnotation(value = "val2")
   void annotatedMethod() { println("annotated method called") }
{code}

should be compiled to this:
{code}
   @MyAnnotationArray({@MyAnnotation("val1"), @MyAnnotation("val2")})
   void annotatedMethod() { println("annotated method called") }
{code}

but actually compiled to this:
{code}
   @MyAnnotation(value = "val1")
   @MyAnnotation(value = "val2")
   void annotatedMethod() { println("annotated method called") }
{code}

The full groovy script to reproduce problem is below.
It throws exception: 
{color:red}java.lang.annotation.AnnotationFormatError: Duplicate annotation for class: interface
MyAnnotation: @MyAnnotation(value=val2){color}

at line `List annos = m.getAnnotations()`


{code}
import java.lang.annotation.*

class MyClass 
{
    @MyAnnotation(value = "val1")
    @MyAnnotation(value = "val2")
    //change annotation to next line and the code will work
    //@MyAnnotationArray( [@MyAnnotation("val1"), @MyAnnotation("val2")] )
    public void annotatedMethod()
    {
      System.out.println("annotated method called");
    }
   public static void main(String... args)
   {
      MyClass ob = new MyClass()
      ob.annotatedMethod()
      java.lang.reflect.Method m = ob.getClass().getMethod("annotatedMethod")
      List annos = m.getAnnotations()
      println("annos = $annos")
   }
}

@Target(ElementType.METHOD)
@Retention(RetentionPolicy.RUNTIME)
@Repeatable(MyAnnotationArray) 
public @interface MyAnnotation
{
    String value() default "val0";
}

@Retention(RetentionPolicy.RUNTIME)
public @interface MyAnnotationArray 
{
   MyAnnotation[] value()
}
{code}



> CLONE - Add @Repeatable java8 annotation support
> ------------------------------------------------
>
>                 Key: GROOVY-8559
>                 URL: https://issues.apache.org/jira/browse/GROOVY-8559
>             Project: Groovy
>          Issue Type: New Feature
>    Affects Versions: 2.5.0-rc-1
>         Environment: groovy 2.4.11
>            Reporter: Dmitry Lukyanov
>            Assignee: Paul King
>            Priority: Major
>             Fix For: 2.5.0-beta-2
>
>
> I cloned the issue to fix another case. For the case of pre-compiled Java annotations,
a check in {{ResolveVisitor#visitAnnotations}} is triggering an error prior to the auto-collecting
of annotations code being handled in {{ExtendedVerifier}}.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message