groovy-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Eric Milles (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (GROOVY-8535) FieldNode constructor appears to call setType incorrectly
Date Fri, 06 Apr 2018 19:33:00 GMT

     [ https://issues.apache.org/jira/browse/GROOVY-8535?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Eric Milles updated GROOVY-8535:
--------------------------------
    Description: 
If initial value expression is non-null, the first call to `setType` appears to have no effect.

{code:java}
    public FieldNode(String name, int modifiers, ClassNode type, ClassNode owner, Expression
initialValueExpression) {
        this.name = name;
        this.modifiers = modifiers;
        this.type = type;
        if (this.type == ClassHelper.DYNAMIC_TYPE && initialValueExpression != null)
            this.setType(initialValueExpression.getType());
        this.setType(type);
{code}

  was:
If initial value expression is non-null, the first call to `setType` appears to have no effect.

```java
    public FieldNode(String name, int modifiers, ClassNode type, ClassNode owner, Expression
initialValueExpression) {
        this.name = name;
        this.modifiers = modifiers;
        this.type = type;
        if (this.type == ClassHelper.DYNAMIC_TYPE && initialValueExpression != null)
            this.setType(initialValueExpression.getType());
        this.setType(type);
```


> FieldNode constructor appears to call setType incorrectly
> ---------------------------------------------------------
>
>                 Key: GROOVY-8535
>                 URL: https://issues.apache.org/jira/browse/GROOVY-8535
>             Project: Groovy
>          Issue Type: Improvement
>    Affects Versions: 2.4.15
>            Reporter: Eric Milles
>            Priority: Major
>
> If initial value expression is non-null, the first call to `setType` appears to have
no effect.
> {code:java}
>     public FieldNode(String name, int modifiers, ClassNode type, ClassNode owner, Expression
initialValueExpression) {
>         this.name = name;
>         this.modifiers = modifiers;
>         this.type = type;
>         if (this.type == ClassHelper.DYNAMIC_TYPE && initialValueExpression !=
null)
>             this.setType(initialValueExpression.getType());
>         this.setType(type);
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message