groovy-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GROOVY-8525) Binary compatibility issue for GroovyClassLoader between 2.4 vs later branches
Date Sat, 31 Mar 2018 02:37:00 GMT

    [ https://issues.apache.org/jira/browse/GROOVY-8525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16421150#comment-16421150
] 

ASF GitHub Bot commented on GROOVY-8525:
----------------------------------------

Github user paulk-asert commented on a diff in the pull request:

    https://github.com/apache/groovy/pull/679#discussion_r178421035
  
    --- Diff: src/main/java/org/codehaus/groovy/runtime/memoize/StampedCommonCache.java ---
    @@ -199,20 +208,35 @@ public int size() {
             return doWithReadLock(c -> c.size());
         }
     
    +    @Override
    +    public boolean isEmpty() {
    +        return commonCache.isEmpty();
    +    }
    +
         /**
          * {@inheritDoc}
          */
         @Override
    -    public V remove(final K key) {
    +    public V remove(final Object key) {
             return doWithWriteLock(c -> c.remove(key));
         }
     
    +    @Override
    +    public void putAll(Map<? extends K, ? extends V> m) {
    +
    --- End diff --
    
    Oops, I was wondering whether to lock for the whole putAll or loop and lock per entry
and then forgot to supply either! I'll do the former for now.


> Binary compatibility issue for GroovyClassLoader between 2.4 vs later branches
> ------------------------------------------------------------------------------
>
>                 Key: GROOVY-8525
>                 URL: https://issues.apache.org/jira/browse/GROOVY-8525
>             Project: Groovy
>          Issue Type: Task
>            Reporter: Paul King
>            Priority: Major
>
> Protected fields {{classCache}} and {{sourceCache}} have type {{EvictableCache}} instead
of {{Map}} in {{java.lang.GroovyClassLoader}}.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message