groovy-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GROOVY-8525) Binary compatibility issue for GroovyClassLoader between 2.4 vs later branches
Date Sat, 31 Mar 2018 02:36:00 GMT

    [ https://issues.apache.org/jira/browse/GROOVY-8525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16421149#comment-16421149
] 

ASF GitHub Bot commented on GROOVY-8525:
----------------------------------------

Github user paulk-asert commented on a diff in the pull request:

    https://github.com/apache/groovy/pull/679#discussion_r178421016
  
    --- Diff: src/main/java/org/codehaus/groovy/runtime/memoize/StampedCommonCache.java ---
    @@ -175,6 +174,11 @@ private V compute(K key, ValueProvider<? super K, ? extends V>
valueProvider, bo
             return doWithReadLock(c -> c.values());
         }
     
    +    @Override
    +    public Set<Entry<K, V>> entrySet() {
    +        return commonCache.entrySet();
    --- End diff --
    
    true, but I think we have to throw UnsupportedOperationException for entrySet and keySet
because they return a view which might then be modified under the covers without locks?


> Binary compatibility issue for GroovyClassLoader between 2.4 vs later branches
> ------------------------------------------------------------------------------
>
>                 Key: GROOVY-8525
>                 URL: https://issues.apache.org/jira/browse/GROOVY-8525
>             Project: Groovy
>          Issue Type: Task
>            Reporter: Paul King
>            Priority: Major
>
> Protected fields {{classCache}} and {{sourceCache}} have type {{EvictableCache}} instead
of {{Map}} in {{java.lang.GroovyClassLoader}}.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message