groovy-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From paulk-asert <...@git.apache.org>
Subject [GitHub] groovy pull request #679: GROOVY-8525: Binary compatibility issue for Groovy...
Date Sat, 31 Mar 2018 02:35:06 GMT
Github user paulk-asert commented on a diff in the pull request:

    https://github.com/apache/groovy/pull/679#discussion_r178421016
  
    --- Diff: src/main/java/org/codehaus/groovy/runtime/memoize/StampedCommonCache.java ---
    @@ -175,6 +174,11 @@ private V compute(K key, ValueProvider<? super K, ? extends V>
valueProvider, bo
             return doWithReadLock(c -> c.values());
         }
     
    +    @Override
    +    public Set<Entry<K, V>> entrySet() {
    +        return commonCache.entrySet();
    --- End diff --
    
    true, but I think we have to throw UnsupportedOperationException for entrySet and keySet
because they return a view which might then be modified under the covers without locks?


---

Mime
View raw message