groovy-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From danielsun1106 <...@git.apache.org>
Subject [GitHub] groovy pull request #679: GROOVY-8525: Binary compatibility issue for Groovy...
Date Sat, 31 Mar 2018 01:43:50 GMT
Github user danielsun1106 commented on a diff in the pull request:

    https://github.com/apache/groovy/pull/679#discussion_r178419989
  
    --- Diff: src/main/java/org/codehaus/groovy/runtime/memoize/StampedCommonCache.java ---
    @@ -199,20 +208,35 @@ public int size() {
             return doWithReadLock(c -> c.size());
         }
     
    +    @Override
    +    public boolean isEmpty() {
    +        return commonCache.isEmpty();
    +    }
    +
         /**
          * {@inheritDoc}
          */
         @Override
    -    public V remove(final K key) {
    +    public V remove(final Object key) {
             return doWithWriteLock(c -> c.remove(key));
         }
     
    +    @Override
    +    public void putAll(Map<? extends K, ? extends V> m) {
    +
    --- End diff --
    
    The implementation is missing and should be protected by `doWithWriteLock`


---

Mime
View raw message