From notifications-return-11078-archive-asf-public=cust-asf.ponee.io@groovy.apache.org Thu Feb 22 12:46:05 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 99B2818067E for ; Thu, 22 Feb 2018 12:46:04 +0100 (CET) Received: (qmail 3658 invoked by uid 500); 22 Feb 2018 11:46:03 -0000 Mailing-List: contact notifications-help@groovy.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@groovy.apache.org Delivered-To: mailing list notifications@groovy.apache.org Received: (qmail 3649 invoked by uid 99); 22 Feb 2018 11:46:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 22 Feb 2018 11:46:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 327FC180033 for ; Thu, 22 Feb 2018 11:46:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.511 X-Spam-Level: X-Spam-Status: No, score=-109.511 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id 9u2oMSVcYBps for ; Thu, 22 Feb 2018 11:46:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 9C13C5F3CC for ; Thu, 22 Feb 2018 11:46:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id B0231E021F for ; Thu, 22 Feb 2018 11:46:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 1C48726312 for ; Thu, 22 Feb 2018 11:46:00 +0000 (UTC) Date: Thu, 22 Feb 2018 11:46:00 +0000 (UTC) From: "Paul King (JIRA)" To: notifications@groovy.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Comment Edited] (GROOVY-8479) sum from DefaultGroovyMethods does not have type information MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/GROOVY-8479?page=3Dcom.atlassia= n.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D163= 72707#comment-16372707 ]=20 Paul King edited comment on GROOVY-8479 at 2/22/18 11:45 AM: ------------------------------------------------------------- From memory it was related to us not requiring {{plus}} to be homogeneous a= nd {{sum}} uses {{plus}} under the covers - apart from some special cases l= ike the {{int[]}} overload where some efficiencies are assumed. Consider: {code} def n1 =3D [1L, 2L, 3L] def n2 =3D [1, 2, 3] def n3 =3D ['a', 'b', 'c'] // types within collection determine result type assert n1.sum(42) instanceof Long assert n3.sum(42) instanceof String // type of initial value determines result type assert n2.sum(42L) instanceof Long assert n2.sum(42) instanceof Integer assert n2.sum('hi') instanceof String {code} But in general, anyone can define any parameter types and return type for {= {plus}}. was (Author: paulk): From memory it was related to us not requiring {{plus}} to be homogeneous a= nd {{sum}} uses {{plus}} under the covers - apart from some special cases l= ike the {{int[]}} overload where some efficiencies are assumed. Consider: {code} def n1 =3D [1L, 2L, 3L] def n2 =3D [1, 2, 3] def n3 =3D ['a', 'b', 'c'] // types within collection determine result type assert n1.sum(42) instanceof Long assert n3.sum(42) instanceof String // type of initial value determines result type assert n2.sum(42L) instanceof Long assert n2.sum(42) instanceof Integer assert n2.sum('hi') instanceof String {code} But in general, anyone can defining any parameter types and return type for= {{plus}}. > sum from DefaultGroovyMethods does not have type information > ------------------------------------------------------------ > > Key: GROOVY-8479 > URL: https://issues.apache.org/jira/browse/GROOVY-8479 > Project: Groovy > Issue Type: Bug > Components: groovy-jdk > Affects Versions: 2.4.13 > Reporter: Michal Kordas > Priority: Major > > Overloads of=C2=A0{{org.codehaus.groovy.runtime.DefaultGroovyMethods#sum}= } are missing type information. I don't see {{@ClosureParams}} or generics = on any of them.=C2=A0 > It should have been done in https://issues.apache.org/jira/browse/GROOVY-= 7283,=C2=A0but for some reason {{sum}} was not modified back then. -- This message was sent by Atlassian JIRA (v7.6.3#76005)