From notifications-return-10967-archive-asf-public=cust-asf.ponee.io@groovy.apache.org Tue Feb 6 13:13:07 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id 0FB4F180657 for ; Tue, 6 Feb 2018 13:13:07 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id F366F160C5B; Tue, 6 Feb 2018 12:13:06 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 4F7D7160C45 for ; Tue, 6 Feb 2018 13:13:06 +0100 (CET) Received: (qmail 71740 invoked by uid 500); 6 Feb 2018 12:13:05 -0000 Mailing-List: contact notifications-help@groovy.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@groovy.apache.org Delivered-To: mailing list notifications@groovy.apache.org Received: (qmail 71509 invoked by uid 99); 6 Feb 2018 12:13:05 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 06 Feb 2018 12:13:05 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 3EE9518032C for ; Tue, 6 Feb 2018 12:13:04 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.511 X-Spam-Level: X-Spam-Status: No, score=-109.511 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id OBxSEzywPWgA for ; Tue, 6 Feb 2018 12:13:03 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id B80615F183 for ; Tue, 6 Feb 2018 12:13:02 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 3AEC9E015E for ; Tue, 6 Feb 2018 12:13:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 461C524102 for ; Tue, 6 Feb 2018 12:13:00 +0000 (UTC) Date: Tue, 6 Feb 2018 12:13:00 +0000 (UTC) From: "Jochen Theodorou (JIRA)" To: notifications@groovy.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (GROOVY-8467) IOGroovyMethods class readLine method works unexpected in MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/GROOVY-8467?page=3Dcom.atlassia= n.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D163= 53786#comment-16353786 ]=20 Jochen Theodorou commented on GROOVY-8467: ------------------------------------------ I think I see the problem now. If we read A\r\nB\r\n, then readLine will ma= ke first a line for A and then the expectation is to have the next line for= B. The loop up there will only consume the \r, not the \n. And this leads = to an empty line. So reading all lines will produce A, empty, B empty. Is t= hat correct? > IOGroovyMethods class readLine method works unexpected in =20 > ----------------------------------------------------------- > > Key: GROOVY-8467 > URL: https://issues.apache.org/jira/browse/GROOVY-8467 > Project: Groovy > Issue Type: Bug > Environment: windows 7 > Reporter: zhuxiaobing > Priority: Major > Attachments: Screenshot from 2018-02-05 13-30-03.png, groovy_test= _linux.zip, groovy_test_win.zip > > > i have a android aapt dump file > i try to read the file use the code below: > =C2=A0 > {code:java} > InputStreamReader inputReader =3D new InputStreamReader(dumpFile) > String line =3D null > while ((line =3D inputReader.readLine()) !=3D null){ > println(line) > } > {code} > the dumpfile uses \r\n to start a new line, while the=C2=A0IOGroovyMethod= s > readLineFromReaderWithoutMark method which called by readLine =C2=A0metho= d=C2=A0 is :=C2=A0 > {code:java} > =C2=A0private static String readLineFromReaderWithoutMark(Reader input) t= hrows IOException { > int c =3D input.read(); > if(c =3D=3D -1) { > return null; > } else { > StringBuilder line; > for(line =3D new StringBuilder(expectedLineLength); c !=3D EOF &&= c !=3D 10 && c !=3D 13; c =3D input.read()) { > char ch =3D (char)c; > line.append(ch); > } > return line.toString(); > } > }{code} > =C2=A0this casues an extra empty line read. -- This message was sent by Atlassian JIRA (v7.6.3#76005)