From notifications-return-10910-archive-asf-public=cust-asf.ponee.io@groovy.apache.org  Wed Jan 31 14:21:31 2018
Return-Path: <notifications-return-10910-archive-asf-public=cust-asf.ponee.io@groovy.apache.org>
X-Original-To: archive-asf-public@eu.ponee.io
Delivered-To: archive-asf-public@eu.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by mx-eu-01.ponee.io (Postfix) with ESMTP id AC988180662
	for <archive-asf-public@eu.ponee.io>; Wed, 31 Jan 2018 14:21:31 +0100 (CET)
Received: by cust-asf.ponee.io (Postfix)
	id 9C815160C35; Wed, 31 Jan 2018 13:21:31 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id DF486160C25
	for <archive-asf-public@cust-asf.ponee.io>; Wed, 31 Jan 2018 14:21:30 +0100 (CET)
Received: (qmail 78316 invoked by uid 500); 31 Jan 2018 13:21:30 -0000
Mailing-List: contact notifications-help@groovy.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:notifications-help@groovy.apache.org>
List-Unsubscribe: <mailto:notifications-unsubscribe@groovy.apache.org>
List-Post: <mailto:notifications@groovy.apache.org>
List-Id: <notifications.groovy.apache.org>
Reply-To: dev@groovy.apache.org
Delivered-To: mailing list notifications@groovy.apache.org
Received: (qmail 78307 invoked by uid 99); 31 Jan 2018 13:21:30 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 31 Jan 2018 13:21:30 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33)
	id 092EDDFC3E; Wed, 31 Jan 2018 13:21:29 +0000 (UTC)
From: jespersm <git@git.apache.org>
To: notifications@groovy.apache.org
Reply-To: notifications@groovy.apache.org
References: <git-pr--groovy@git.apache.org>
In-Reply-To: <git-pr--groovy@git.apache.org>
Subject: [GitHub] groovy pull request #: 
Content-Type: text/plain
Message-Id: <20180131132130.092EDDFC3E@git1-us-west.apache.org>
Date: Wed, 31 Jan 2018 13:21:29 +0000 (UTC)

Github user jespersm commented on the pull request:

    https://github.com/apache/groovy/commit/c24c0b7e6a67dcdf277207d4261cfa6f2b55031f#commitcomment-27234580
  
    In src/main/java/org/codehaus/groovy/classgen/asm/InvocationWriter.java:
    In src/main/java/org/codehaus/groovy/classgen/asm/InvocationWriter.java on line 483:
    True, we should only do this for objects implementing a single SAM. That would still cover the typical usecases.


---