From notifications-return-10905-archive-asf-public=cust-asf.ponee.io@groovy.apache.org Wed Jan 31 13:42:02 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id 99B6D180662 for ; Wed, 31 Jan 2018 13:42:02 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 8991F160C35; Wed, 31 Jan 2018 12:42:02 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id CAE61160C25 for ; Wed, 31 Jan 2018 13:42:01 +0100 (CET) Received: (qmail 80246 invoked by uid 500); 31 Jan 2018 12:42:01 -0000 Mailing-List: contact notifications-help@groovy.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@groovy.apache.org Delivered-To: mailing list notifications@groovy.apache.org Received: (qmail 80237 invoked by uid 99); 31 Jan 2018 12:42:01 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 31 Jan 2018 12:42:01 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id E0630E01EC; Wed, 31 Jan 2018 12:42:00 +0000 (UTC) From: jespersm To: notifications@groovy.apache.org Reply-To: notifications@groovy.apache.org References: In-Reply-To: Subject: [GitHub] groovy pull request #: Content-Type: text/plain Message-Id: <20180131124200.E0630E01EC@git1-us-west.apache.org> Date: Wed, 31 Jan 2018 12:42:00 +0000 (UTC) Github user jespersm commented on the pull request: https://github.com/apache/groovy/commit/c24c0b7e6a67dcdf277207d4261cfa6f2b55031f#commitcomment-27233916 In src/main/java/org/codehaus/groovy/transform/stc/StaticTypeCheckingVisitor.java: In src/main/java/org/codehaus/groovy/transform/stc/StaticTypeCheckingVisitor.java on line 4104: Yes, but instead of adding a "fake" call method, you could modify the call invocation to use the SAM's selector name instead. I still think you should separate the two, I don't see why they need to be coupled together -- the PR is big enough as it is. ---