groovy-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jespersm <...@git.apache.org>
Subject [GitHub] groovy pull request #:
Date Wed, 31 Jan 2018 12:42:00 GMT
Github user jespersm commented on the pull request:

    https://github.com/apache/groovy/commit/c24c0b7e6a67dcdf277207d4261cfa6f2b55031f#commitcomment-27233916
  
    In src/main/java/org/codehaus/groovy/transform/stc/StaticTypeCheckingVisitor.java:
    In src/main/java/org/codehaus/groovy/transform/stc/StaticTypeCheckingVisitor.java on line
4104:
    Yes, but instead of adding a "fake" call method, you could modify the call invocation
to use the SAM's selector name instead.
    I still think you should separate the two, I don't see why they need to be coupled together
-- the PR is big enough as it is.


---

Mime
View raw message