groovy-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Paul King (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GROOVY-8426) Incorrect line and column numbers are assigned to BlockStatements generated out of method definitions
Date Sun, 31 Dec 2017 03:06:00 GMT

    [ https://issues.apache.org/jira/browse/GROOVY-8426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16307049#comment-16307049
] 

Paul King commented on GROOVY-8426:
-----------------------------------

Thanks for your PRs! WRT master being already fixed, I noticed that if I set -Dgroovy.antlr4=false
in master I get the same error and on 2.6 if I set that flag to true I don't get the error
but otherwise all looks good. Don't create another PR though - it's just as easy (and better
for tracking) for me to cherry-pick the change in master onto the other branches where the
source files are in the same directory, i.e. all except 2_4_X. The only thing I wanted to
check was coverage. One of the historic commits in the area of this change talks about a whole
block being classed as covered if only one line was executed - so I just want to check that
doesn't happen here before applying.

> Incorrect line and column numbers are assigned to BlockStatements generated out of method
definitions
> -----------------------------------------------------------------------------------------------------
>
>                 Key: GROOVY-8426
>                 URL: https://issues.apache.org/jira/browse/GROOVY-8426
>             Project: Groovy
>          Issue Type: Bug
>    Affects Versions: 2.5.0-beta-2, 2.4.13, 2.6.0-alpha-2
>            Reporter: Marcin Erdmann
>            Priority: Minor
>              Labels: pull-request-available
>
> Line and column numbers assigned to BlockStatements generated out of method definitions
in {{AntlrParserPlugin#methodDef(AST)}} are incorrect. The ones used are for the first statement
inside of the block and not for the whole block.
> Note that this seems to be fixed on master (in parrot?) but not in any pre-3.0 versions
which are still maintained.
> A PR to follow.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message