Mailing-List: contact notifications-help@groovy.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@groovy.apache.org
From: AndrewReitz <git@git.apache.org>
To: notifications@groovy.apache.org
Reply-To: notifications@groovy.apache.org
References: <git-pr-631-groovy@git.apache.org>
In-Reply-To: <git-pr-631-groovy@git.apache.org>
Subject: [GitHub] groovy pull request #631: Android: Remove Invoke Dynamic Call
Content-Type: text/plain
Message-Id: <20171109142339.7DDBADFB3D@git1-us-west.apache.org>
Date: Thu,  9 Nov 2017 14:23:39 +0000 (UTC)
archived-at: Thu, 09 Nov 2017 14:23:41 -0000

Github user AndrewReitz commented on a diff in the pull request:

    https://github.com/apache/groovy/pull/631#discussion_r149974307
  
    --- Diff: gradle/assemble.gradle ---
    @@ -247,6 +247,7 @@ allprojects {
                             if (isRootProject) {
                                 zipfileset(src: rootProject.configurations.runtime.files.find { it.name.startsWith('openbeans') }, excludes: 'META-INF/*')
                             }
    +                        zap pattern: 'org.codehaus.groovy.vmplugin.v7.IndyInterface'
    --- End diff --
    
    What do you think about having two android jars one without classes that use invoke dynamic and one with them still? 
    
    It looks like Android will be supporting it on ap's 26+. The issue is that Google added a check for classes using the invoke-polymorphic. Little more info here. https://issuetracker.google.com/issues/37567710
    
    I am able to use proguard to remove the classes that cause the failure, but it increases build times greatly.


---