groovy-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Uwe Schindler (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GROOVY-8387) Invalid module-info.class in jar artifacts
Date Mon, 20 Nov 2017 15:41:01 GMT

    [ https://issues.apache.org/jira/browse/GROOVY-8387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16259375#comment-16259375
] 

Uwe Schindler commented on GROOVY-8387:
---------------------------------------

I think when packaging JARs that use something like Maven Shade Plugin / Jarjar (or similar),
you should explicitely exclude module-info.class when building the zipfileset to call JARJAR
using an exclude. Other packaged libs (not only ASM) may suddenly include this file. This
hurts especially uber-jars.

IMHO, we should also file bugs at Maven and Gradle to take care that their shading/packagerewrite/uber-jar
plugins take care of that exclusion automatically.

FYI, when using ANT with Jarjar Bings I had a similar issue and this was fixed for me like
that: https://github.com/policeman-tools/forbidden-apis/commit/1654d5d38e40ee500ca7ae82b146ed6fcfba0827

> Invalid module-info.class in jar artifacts
> ------------------------------------------
>
>                 Key: GROOVY-8387
>                 URL: https://issues.apache.org/jira/browse/GROOVY-8387
>             Project: Groovy
>          Issue Type: Bug
>    Affects Versions: 3.x, 2.6.0-alpha-2
>            Reporter: Paul King
>
> Due to jarjar of ASM 6, we get a bogus module-info.class file in our artifacts on master
and GROOVY_2_6_X. We need to prune this out in the gradle build file.
> We want to ultimately have our own such file but we haven't worked out what its contents
would be yet and that will have its own issue.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message