groovy-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GROOVY-8376) Add @DelegatesTo to SwingBuilder methods that call setDelegate
Date Sat, 11 Nov 2017 12:52:00 GMT

    [ https://issues.apache.org/jira/browse/GROOVY-8376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16248506#comment-16248506
] 

ASF GitHub Bot commented on GROOVY-8376:
----------------------------------------

GitHub user paulk-asert opened a pull request:

    https://github.com/apache/groovy/pull/632

    GROOVY-8376: Add @DelegatesTo to SwingBuilder methods that call setDe…

    …legate

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/paulk-asert/groovy groovy8376

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/groovy/pull/632.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #632
    
----
commit fbc6093f5890f0170b568f24681648550f7b4dc1
Author: paulk <paulk@asert.com.au>
Date:   2017-11-11T12:49:59Z

    GROOVY-8376: Add @DelegatesTo to SwingBuilder methods that call setDelegate

----


> Add @DelegatesTo to SwingBuilder methods that call setDelegate
> --------------------------------------------------------------
>
>                 Key: GROOVY-8376
>                 URL: https://issues.apache.org/jira/browse/GROOVY-8376
>             Project: Groovy
>          Issue Type: Improvement
>            Reporter: Eric Milles
>
> 4 mehtods in SwingBuilder (edt, doLater, doOutside, build) call setDelegate(this) on
their closure params.  Could each have the param annotated with {{@DelegatesTo(SwingBuilder)}}?
> Ex:
> {code}
>     public Object build(@DelegatesTo(SwingBuilder) Closure c) {
>         c.setDelegate(this)
>         return c.call()
>     }
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message