groovy-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From AndrewReitz <...@git.apache.org>
Subject [GitHub] groovy pull request #631: Android: Remove Invoke Dynamic Call
Date Thu, 09 Nov 2017 14:23:39 GMT
Github user AndrewReitz commented on a diff in the pull request:

    https://github.com/apache/groovy/pull/631#discussion_r149974307
  
    --- Diff: gradle/assemble.gradle ---
    @@ -247,6 +247,7 @@ allprojects {
                             if (isRootProject) {
                                 zipfileset(src: rootProject.configurations.runtime.files.find
{ it.name.startsWith('openbeans') }, excludes: 'META-INF/*')
                             }
    +                        zap pattern: 'org.codehaus.groovy.vmplugin.v7.IndyInterface'
    --- End diff --
    
    What do you think about having two android jars one without classes that use invoke dynamic
and one with them still? 
    
    It looks like Android will be supporting it on ap's 26+. The issue is that Google added
a check for classes using the invoke-polymorphic. Little more info here. https://issuetracker.google.com/issues/37567710
    
    I am able to use proguard to remove the classes that cause the failure, but it increases
build times greatly.


---

Mime
View raw message