groovy-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From blackdrag <...@git.apache.org>
Subject [GitHub] groovy pull request #631: Android: Remove Invoke Dynamic Call
Date Thu, 09 Nov 2017 01:44:11 GMT
Github user blackdrag commented on a diff in the pull request:

    https://github.com/apache/groovy/pull/631#discussion_r149848170
  
    --- Diff: gradle/assemble.gradle ---
    @@ -247,6 +247,7 @@ allprojects {
                             if (isRootProject) {
                                 zipfileset(src: rootProject.configurations.runtime.files.find
{ it.name.startsWith('openbeans') }, excludes: 'META-INF/*')
                             }
    +                        zap pattern: 'org.codehaus.groovy.vmplugin.v7.IndyInterface'
    --- End diff --
    
    normally the Groovy version, that does not use indy, means indy is not used for Groovy
itself, but the user can still use it. You pullrequest will mean that this is no longer possible.
 You have to at least also add the Java7 class, or else there will be class loading trouble.
And the instantiation of that class would have to change. A bigger problem are the classes
from org.codehaus.groovy.classgen.asm.indy, which do reference this class as well. Without
further steps the groovy runtime and the compiler would get into trouble on a Java7 JVM or
higher. 


---

Mime
View raw message