Mailing-List: contact notifications-help@groovy.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@groovy.apache.org
Date: Thu, 12 Oct 2017 14:55:00 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: notifications@groovy.apache.org
Message-ID: <JIRA.13108634.1507732347000.40901.1507820100712@Atlassian.JIRA>
In-Reply-To: <JIRA.13108634.1507732347000@Atlassian.JIRA>
References: <JIRA.13108634.1507732347000@Atlassian.JIRA> <JIRA.13108634.1507732347596@jira-lw-us.apache.org>
Subject: [jira] [Commented] (GROOVY-8352) Add a @Generated annotation to
 mark generated members
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
archived-at: Thu, 12 Oct 2017 14:55:07 -0000


    [ https://issues.apache.org/jira/browse/GROOVY-8352?page=3Dcom.atlassia=
n.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D162=
02057#comment-16202057 ]=20

ASF GitHub Bot commented on GROOVY-8352:
----------------------------------------

Github user aalmiray commented on a diff in the pull request:

    https://github.com/apache/groovy/pull/617#discussion_r144314040
 =20
    --- Diff: src/main/org/codehaus/groovy/classgen/Verifier.java ---
    @@ -384,6 +387,7 @@ public void visit(MethodVisitor mv) {
         protected void addGroovyObjectInterfaceAndMethods(ClassNode node, =
final String classInternalName) {
             if (!node.isDerivedFromGroovyObject()) node.addInterface(Class=
Helper.make(GroovyObject.class));
             FieldNode metaClassField =3D getMetaClassField(node);
    +        AnnotationNode generatedAnnotation =3D new AnnotationNode(Clas=
sHelper.make(GENERATED_ANNOTATION));
    =20
    --- End diff --
   =20
    2 small fixes added =F0=9F=98=84=20


> Add a @Generated annotation to mark generated members
> -----------------------------------------------------
>
>                 Key: GROOVY-8352
>                 URL: https://issues.apache.org/jira/browse/GROOVY-8352
>             Project: Groovy
>          Issue Type: New Feature
>          Components: class generator
>    Affects Versions: 2.6.0-alpha-1
>            Reporter: Andres Almiray
>
> Rationale:
> Tooling support for Groovy may benefit from having additional information=
 on generated members. We already provide some information by marking certa=
in generated methods as synthetic, however tools such as IDEs hide these me=
thods. The goal of `@Generated` is to mark members that are still visible t=
o IDEs and other tools.
> Example:
> The JaCoCo and Lombok projects have agreed on an annotation named `@lombo=
k.Generated`. This annotation serves as a hint to JaCoCo in order to skip c=
overage on the annotated elements; this helps JaCoCo in reporting more accu=
rate coverage numbers for source code.
> What would be needed:
> An annotation in the groovy space named `@Generated` that can be used by =
JaCoCo (or any other tool). We can't use `@javax.annotation.Generated` beca=
use its retention policy is `SOURCE` and we need `CLASS` at the very least.
> Modify the Verifier to mark the 5 default GroovyObject methods with this =
annotation when the inspected class does not provide an implementation for =
any of these methods.
> Additionally, any AST transformation that creates additional methods/type=
s/fields that should be marked can make use of the new annotation.
> The work required for JaCoCo has already been started and is tracked by h=
ttps://github.com/jacoco/jacoco/pull/610


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)