Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id F0184200D36 for ; Mon, 2 Oct 2017 02:37:09 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id EEC191609C8; Mon, 2 Oct 2017 00:37:09 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 46D861609D9 for ; Mon, 2 Oct 2017 02:37:09 +0200 (CEST) Received: (qmail 88477 invoked by uid 500); 2 Oct 2017 00:37:08 -0000 Mailing-List: contact notifications-help@groovy.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@groovy.apache.org Delivered-To: mailing list notifications@groovy.apache.org Received: (qmail 88458 invoked by uid 99); 2 Oct 2017 00:37:08 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 02 Oct 2017 00:37:08 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 107EAD7AD5 for ; Mon, 2 Oct 2017 00:37:08 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.202 X-Spam-Level: X-Spam-Status: No, score=-99.202 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id c6VWe8BnxoH8 for ; Mon, 2 Oct 2017 00:37:07 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id BA92D5FC12 for ; Mon, 2 Oct 2017 00:37:06 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 24F61E0EE9 for ; Mon, 2 Oct 2017 00:37:05 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 1DD78242BE for ; Mon, 2 Oct 2017 00:37:02 +0000 (UTC) Date: Mon, 2 Oct 2017 00:37:02 +0000 (UTC) From: "Paul King (JIRA)" To: notifications@groovy.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Resolved] (GROOVY-8326) @Override should not copied onto methods generated by applying @Memoize MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Mon, 02 Oct 2017 00:37:10 -0000 [ https://issues.apache.org/jira/browse/GROOVY-8326?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Paul King resolved GROOVY-8326. ------------------------------- Resolution: Fixed Assignee: John Wagenleitner Fix Version/s: 2.4.13 John's PR applied. Thanks all. > @Override should not copied onto methods generated by applying @Memoize > ----------------------------------------------------------------------- > > Key: GROOVY-8326 > URL: https://issues.apache.org/jira/browse/GROOVY-8326 > Project: Groovy > Issue Type: Bug > Affects Versions: 2.4.12 > Reporter: Marcin Erdmann > Assignee: John Wagenleitner > Priority: Minor > Labels: ast > Fix For: 2.4.13 > > > Applying {{@Memoized}} onto a method already annotated with {{@Override}} will result in a compilation error along the lines of: > {quote} > Method 'memoizedMethodPriv$...' from class '...' does not override method from its superclass or interfaces but is annotated with @Override. > {quote} > This is because all annotations of the method annotated with {{@Memoized}} are copied onto the method generated by the AST [here|https://github.com/apache/groovy/blob/731d4daa78b9cd32bea724d2d651aa1164eef6cc/src/main/org/codehaus/groovy/transform/MemoizedASTTransformation.java#L131]. In my opinion {{java.lang.Override}} should be filtered out. -- This message was sent by Atlassian JIRA (v6.4.14#64029)