groovy-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GROOVY-8360) Enums that are nested classes do not have the static modifier set
Date Fri, 20 Oct 2017 00:21:00 GMT

    [ https://issues.apache.org/jira/browse/GROOVY-8360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16211972#comment-16211972
] 

ASF GitHub Bot commented on GROOVY-8360:
----------------------------------------

GitHub user shils opened a pull request:

    https://github.com/apache/groovy/pull/619

    GROOVY-8360: Enums that are inner classes should have the static clas…

    …s modifier

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/shils/groovy GROOVY-8360

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/groovy/pull/619.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #619
    
----
commit 8a0d193ba392d5a5e3ec417d1e708d4cee856627
Author: Shil Sinha <shil.sinha@gmail.com>
Date:   2017-10-19T22:37:23Z

    GROOVY-8360: Enums that are inner classes should have the static class modifier

----


> Enums that are nested classes do not have the static modifier set
> -----------------------------------------------------------------
>
>                 Key: GROOVY-8360
>                 URL: https://issues.apache.org/jira/browse/GROOVY-8360
>             Project: Groovy
>          Issue Type: Bug
>          Components: Compiler
>    Affects Versions: 3.x, 2.6.0-alpha-1, 2.4.12, 2.5.0-beta-2
>            Reporter: Shil Sinha
>
> In java, enums that are nested classes have the static modifier set i.e. if Bar is an
enum defined within a class Foo, {{assert Modifier.isStatic(Foo.Bar.modifiers)}} passes. The
assertion does not hold if Foo and Bar are defined in groovy:
> {code}
> class Foo {
>     enum Bar {
>         X
>     }
> }
>             
> assert java.lang.reflect.Modifier.isStatic(Foo.Bar.modifiers)
> {code}
> This can be problematic in cases like https://mongodb.github.io/morphia/, where the type
of a mapped field cannot be a non-static inner class. Of course that library could also be
more enum-aware when validating mapped fields, but that's a separate issue. 
> A simple workaround for this issue is to explicitly declare the enum as static, so it's
not critical that a patch for this be in 2.4.X if it's considered a breaking change (though
no tests fail with the change.)



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message