groovy-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GROOVY-8326) @Override should not copied onto methods generated by applying @Memoize
Date Sun, 01 Oct 2017 21:05:00 GMT

    [ https://issues.apache.org/jira/browse/GROOVY-8326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16187537#comment-16187537
] 

ASF GitHub Bot commented on GROOVY-8326:
----------------------------------------

Github user asfgit closed the pull request at:

    https://github.com/apache/groovy/pull/610


> @Override should not copied onto methods generated by applying @Memoize
> -----------------------------------------------------------------------
>
>                 Key: GROOVY-8326
>                 URL: https://issues.apache.org/jira/browse/GROOVY-8326
>             Project: Groovy
>          Issue Type: Bug
>    Affects Versions: 2.4.12
>            Reporter: Marcin Erdmann
>            Priority: Minor
>              Labels: ast
>
> Applying {{@Memoized}} onto a method already annotated with {{@Override}} will result
in a compilation error along the lines of:
> {quote}
> Method 'memoizedMethodPriv$...' from class '...' does not override method from its superclass
or interfaces but is annotated with @Override.
> {quote}
> This is because all annotations of the method annotated with {{@Memoized}} are copied
onto the method generated by the AST [here|https://github.com/apache/groovy/blob/731d4daa78b9cd32bea724d2d651aa1164eef6cc/src/main/org/codehaus/groovy/transform/MemoizedASTTransformation.java#L131].
In my opinion {{java.lang.Override}} should be filtered out.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message