groovy-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Paul King (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (GROOVY-8260) Static compilation requires casting inside instanceof check
Date Sun, 24 Sep 2017 11:50:01 GMT

     [ https://issues.apache.org/jira/browse/GROOVY-8260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Paul King resolved GROOVY-8260.
-------------------------------
       Resolution: Fixed
         Assignee: Paul King
    Fix Version/s: 2.4.13

Proposed PR applied. Thanks for spotting the issue.

> Static compilation requires casting inside instanceof check
> -----------------------------------------------------------
>
>                 Key: GROOVY-8260
>                 URL: https://issues.apache.org/jira/browse/GROOVY-8260
>             Project: Groovy
>          Issue Type: Bug
>          Components: Compiler
>    Affects Versions: 2.4.12
>         Environment: macOS JDK 1.8
>            Reporter: James Kleeh
>            Assignee: Paul King
>             Fix For: 2.4.13
>
>
> There are many times I find myself having to cast variables directly inside an {{instanceof
Class}} check.
> In addition, I have found a specific problem with a generic {{<T extends SomeClass>}}
where a method in the class that returns {{T}}, Groovy believes a collection is being returned.
This is the line in question: https://github.com/grails/gorm-graphql/blob/ea6887bef0ced75d9cc0d01dc7b94d4fc0520266/core/src/main/groovy/org/grails/gorm/graphql/fetcher/impl/EntityDataFetcher.groovy#L45
> The goal of this issue is to have the following codebase compile without changes.
> {{git clone -b broken_compilation https://github.com/grails/gorm-graphql}}
> Attempt to compile with {{./gradlew clean classes}}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message