Mailing-List: contact notifications-help@groovy.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@groovy.apache.org
Date: Mon, 14 Aug 2017 17:20:00 +0000 (UTC)
From: "Antoine Kapps (JIRA)" <jira@apache.org>
To: notifications@groovy.apache.org
Message-ID: <JIRA.13094538.1502731168000.26916.1502731200432@Atlassian.JIRA>
In-Reply-To: <JIRA.13094538.1502731168000@Atlassian.JIRA>
References: <JIRA.13094538.1502731168000@Atlassian.JIRA> <JIRA.13094538.1502731168816@jira-lw-us.apache.org>
Subject: [jira] [Created] (GROOVY-8288) [Sql] withBatch fails when batchSize
 == number of addBatch call
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Mon, 14 Aug 2017 17:20:05 -0000

Antoine Kapps created GROOVY-8288:
-------------------------------------

             Summary: [Sql] withBatch fails when batchSize == number of addBatch call
                 Key: GROOVY-8288
                 URL: https://issues.apache.org/jira/browse/GROOVY-8288
             Project: Groovy
          Issue Type: Bug
          Components: SQL processing
    Affects Versions: 2.4.12, 2.5.0-beta-1
            Reporter: Antoine Kapps


{{Sql.withBatch(batchSize, ..)}} calls {{delegate.executeBatch()}} both when batchCount reaches batchSize, and at the end of the method (after the call to the "batch statement" closure).

Thus, if {{batchSize}} is exactly the same as the number of {{addBatch()}} calls in the closure, one too much call to {{executeBatch()}} is made : nothing has been added to the batch.
Which, at least with HSQLDB 2.4.0, leads to a SQLException on that very last call.

Test to reproduce (compliant with SqlBatchTest)
{code:java}
void testWithBatchSizeHavingSizeSameSizeAsStatements() {
    def numRows = sql.rows("SELECT * FROM PERSON").size()
    assert numRows == 3
    def myOthers = ['f4':'l4','f5':'l5','f6':'l6','f7':'l7']
    def result = sql.withBatch(myOthers.size(), "insert into PERSON (id, firstname, lastname) values (?, ?, ?)") { ps ->
        myOthers.eachWithIndex { k, v, index ->
            def id = index + numRows + 1
            ps.addBatch(id, k, v)
        }
    }
    assert result == [1] * myOthers.size()
    assert sql.rows("SELECT * FROM PERSON").size() == numRows + myOthers.size()
    // end result the same as if no batching was in place but logging should show:
    // FINE: Successfully executed batch with 4 command(s)
}
{code}


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)