groovy-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From akapps <...@git.apache.org>
Subject [GitHub] groovy pull request #585: [Sql] Factorizes batchCount incrementation and thu...
Date Mon, 14 Aug 2017 16:14:39 GMT
GitHub user akapps opened a pull request:

    https://github.com/apache/groovy/pull/585

    [Sql] Factorizes batchCount incrementation and thus executeBatch() execution

    Code duplication.
    
    We could restrain "batchCount" and "batchSize" visibility, but this would be a possible
API breakage.
    Also `incrementBatchCount()` method could be package-private, so that it is not published
as part of the inherited API, but I couldn't find a good reason why. It could be final, but
as `processResult(int[])` isn't, I sticked to the same logic.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/akapps/groovy duplicated-increment-batchcount

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/groovy/pull/585.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #585
    
----
commit 584c1956f606000d0bb91e09ef2542c1269a999b
Author: Antoine Kapps <antoine.kapps@zas.admin.ch>
Date:   2017-08-14T16:03:35Z

    Factorizes batchCount incrementation and thus executeBatch() execution

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message