Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id A598D200CBF for ; Sat, 8 Jul 2017 21:32:54 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 9C8C916B2FA; Sat, 8 Jul 2017 19:32:54 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id DB03A16B2F9 for ; Sat, 8 Jul 2017 21:32:53 +0200 (CEST) Received: (qmail 47307 invoked by uid 500); 8 Jul 2017 19:32:53 -0000 Mailing-List: contact notifications-help@groovy.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@groovy.apache.org Delivered-To: mailing list notifications@groovy.apache.org Received: (qmail 47298 invoked by uid 99); 8 Jul 2017 19:32:52 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 08 Jul 2017 19:32:52 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id D8324DFB94; Sat, 8 Jul 2017 19:32:52 +0000 (UTC) From: ArsenBabakhanyan To: notifications@groovy.apache.org Reply-To: notifications@groovy.apache.org References: In-Reply-To: Subject: [GitHub] groovy pull request #559: GROOVY-8222: Setting Source Position in newly crea... Content-Type: text/plain Message-Id: <20170708193252.D8324DFB94@git1-us-west.apache.org> Date: Sat, 8 Jul 2017 19:32:52 +0000 (UTC) archived-at: Sat, 08 Jul 2017 19:32:54 -0000 Github user ArsenBabakhanyan commented on a diff in the pull request: https://github.com/apache/groovy/pull/559#discussion_r126288571 --- Diff: src/main/org/codehaus/groovy/classgen/AsmClassGenerator.java --- @@ -1218,7 +1218,7 @@ public void visitVariableExpression(VariableExpression expression) { BytecodeVariable variable = controller.getCompileStack().getVariable(variableName, false); if (variable == null) { - processClassVariable(variableName); + processClassVariable(expression); --- End diff -- this PR is closed, as I have mentioned before i am planning to do some refactoring and creating a new PR, I will make expression final there --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---