groovy-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ArsenBabakhanyan <...@git.apache.org>
Subject [GitHub] groovy pull request #559: GROOVY-8222: Setting Source Position in newly crea...
Date Sat, 08 Jul 2017 19:32:52 GMT
Github user ArsenBabakhanyan commented on a diff in the pull request:

    https://github.com/apache/groovy/pull/559#discussion_r126288571
  
    --- Diff: src/main/org/codehaus/groovy/classgen/AsmClassGenerator.java ---
    @@ -1218,7 +1218,7 @@ public void visitVariableExpression(VariableExpression expression)
{
     
             BytecodeVariable variable = controller.getCompileStack().getVariable(variableName,
false);
             if (variable == null) {
    -            processClassVariable(variableName);
    +            processClassVariable(expression);
    --- End diff --
    
    this PR is closed, as I have mentioned before i am planning to do some refactoring and
creating a new PR, I will make expression final there 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message