Mailing-List: contact notifications-help@groovy.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@groovy.apache.org
From: jwagenleitner <git@git.apache.org>
To: notifications@groovy.apache.org
Reply-To: notifications@groovy.apache.org
References: <git-pr-560-groovy@git.apache.org>
In-Reply-To: <git-pr-560-groovy@git.apache.org>
Subject: [GitHub] groovy pull request #560: GROOVY-8226: JSR308 initial plumbing tweaks
Content-Type: text/plain
Message-Id: <20170612144725.18109DFE15@git1-us-west.apache.org>
Date: Mon, 12 Jun 2017 14:47:25 +0000 (UTC)
archived-at: Mon, 12 Jun 2017 14:47:26 -0000

Github user jwagenleitner commented on a diff in the pull request:

    https://github.com/apache/groovy/pull/560#discussion_r121416370
  
    --- Diff: src/main/org/codehaus/groovy/vmplugin/vm8/Java8.java ---
    @@ -51,4 +53,13 @@ public int getVersion() {
             return 8;
         }
     
    +    protected int getElementCode(ElementType value) {
    --- End diff --
    
    might be good to have `@Override`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---