groovy-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Denis Jouvin (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GROOVY-8227) Allow to specify Groovysh (and GroovyShell) class loader different from TCCL
Date Thu, 15 Jun 2017 14:13:01 GMT

    [ https://issues.apache.org/jira/browse/GROOVY-8227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16050536#comment-16050536
] 

Denis Jouvin commented on GROOVY-8227:
--------------------------------------

I agree that my script does not show much, since I don't really know which class should be
loaded by the Groovy Shell used by Groovysh, and which is loaded by the script itself (and
thus is probably using the TCCL).

However, from an OSGi environement, when you launch a Groovysh session, you have a class loading
issue related to the instanciation of the VisitorClassLoader, as described above.

The workaround for me was to temporarily set the TCCL to be the right bundle class loader,
instanciate and run the Groovysh session, and then restore the TCCL with the previous value.
But this seems an ugly hack and is not really compatible with multi-htreading I guess.



> Allow to specify Groovysh (and GroovyShell) class loader different from TCCL
> ----------------------------------------------------------------------------
>
>                 Key: GROOVY-8227
>                 URL: https://issues.apache.org/jira/browse/GROOVY-8227
>             Project: Groovy
>          Issue Type: Bug
>          Components: groovy-runtime, Groovysh
>    Affects Versions: 2.4.x, 2.5.x
>         Environment: OSGi (Karaf 2.x, 3.X or 4.x)
>            Reporter: Denis Jouvin
>              Labels: classloader, groovysh, groovyshell
>             Fix For: 2.4.x, 2.5.x
>
>   Original Estimate: 48h
>  Remaining Estimate: 48h
>
> Allthough the Groovy API seem to allow one to specify the class loader when instanciating
a Groovysh or GroovyShell, internally in some places Groovy will silently use the TCCL (thread
context class loader) and there is no way to avoid that without hacking Groovy and chasing
all the places where {{getThreadContextClassLoader()}} is used.
> This is problematic, especially in OSGi environement, since the TCCL is not compatible
with OSGi principles (i.e. every bundle has its own class loader), and also with some modern
modular containers similar to OSGi. When a class loader is specified in the GroovyShell or
Groovysh creation, Groovy should propagate that class loader correctly (or instanciate children
class loader of that specified class loader), and in no way use the TCCL.
> This may be a dupplicate of [Groovy 4895|https://issues.apache.org/jira/browse/GROOVY-4895]



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message