groovy-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GROOVY-8226) JSR308 initial plumbing tweaks
Date Mon, 12 Jun 2017 14:48:00 GMT

    [ https://issues.apache.org/jira/browse/GROOVY-8226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16046645#comment-16046645
] 

ASF GitHub Bot commented on GROOVY-8226:
----------------------------------------

Github user jwagenleitner commented on a diff in the pull request:

    https://github.com/apache/groovy/pull/560#discussion_r121416370
  
    --- Diff: src/main/org/codehaus/groovy/vmplugin/vm8/Java8.java ---
    @@ -51,4 +53,13 @@ public int getVersion() {
             return 8;
         }
     
    +    protected int getElementCode(ElementType value) {
    --- End diff --
    
    might be good to have `@Override`


> JSR308 initial plumbing tweaks
> ------------------------------
>
>                 Key: GROOVY-8226
>                 URL: https://issues.apache.org/jira/browse/GROOVY-8226
>             Project: Groovy
>          Issue Type: Sub-task
>            Reporter: Paul King
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message