Mailing-List: contact notifications-help@groovy.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@groovy.apache.org
Date: Wed, 31 May 2017 18:18:04 +0000 (UTC)
From: "Eric Milles (JIRA)" <jira@apache.org>
To: notifications@groovy.apache.org
Message-ID: <JIRA.13076252.1496252769000.334061.1496254684640@Atlassian.JIRA>
In-Reply-To: <JIRA.13076252.1496252769000@Atlassian.JIRA>
References: <JIRA.13076252.1496252769000@Atlassian.JIRA> <JIRA.13076252.1496252769562@jira-lw-us.apache.org>
Subject: [jira] [Updated] (GROOVY-8210) Unicode escape sequence in string
 literal yields incorrect source position
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Wed, 31 May 2017 18:18:14 -0000


     [ https://issues.apache.org/jira/browse/GROOVY-8210?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Eric Milles updated GROOVY-8210:
--------------------------------
    Description: 
This seems related to GROOVY-4378.  If I enter {code}'\u0047'{code} into the Groovy Console and inspect the AST, I find the string literal's ConstantExpression has been assigned colums 6 to 9.  A start position of 6 propagates to the parent return statement, block statement, etc.  The start position should be column 1.

I believe the UnicodeEscapingReader is stepping in front of the parser and so it never gets to process the original source characters '\', 'u', '0', '0', '4', '7'.

Having incorrect source location for string literals such as this inhibits proper editing/refactoring in the IDE.

  was:
This seems related to GROOVY-4378.  If I enter {code}'\u0047'{code} into the Groovy Console and inspect the AST, I find the string literal has been assigned colums 6 to 9.  A start position of 9 propagates to the parent return statement, block statement, etc.

I believe the UnicodeEscapingReader is stepping in front of the parser and so it never gets to process the original source characters '\', 'u', '0', '0', '4', '7'.

Having incorrect source location for string literals such as this inhibits proper editing/refactoring in the IDE.


> Unicode escape sequence in string literal yields incorrect source position
> --------------------------------------------------------------------------
>
>                 Key: GROOVY-8210
>                 URL: https://issues.apache.org/jira/browse/GROOVY-8210
>             Project: Groovy
>          Issue Type: Bug
>            Reporter: Eric Milles
>
> This seems related to GROOVY-4378.  If I enter {code}'\u0047'{code} into the Groovy Console and inspect the AST, I find the string literal's ConstantExpression has been assigned colums 6 to 9.  A start position of 6 propagates to the parent return statement, block statement, etc.  The start position should be column 1.
> I believe the UnicodeEscapingReader is stepping in front of the parser and so it never gets to process the original source characters '\', 'u', '0', '0', '4', '7'.
> Having incorrect source location for string literals such as this inhibits proper editing/refactoring in the IDE.


--
This message was sent by Atlassian JIRA
(v6.3.15#6346)