Mailing-List: contact notifications-help@groovy.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@groovy.apache.org
Date: Fri, 26 May 2017 05:54:04 +0000 (UTC)
From: "Paul King (JIRA)" <jira@apache.org>
To: notifications@groovy.apache.org
Message-ID: <JIRA.13075051.1495766173000.299964.1495778044053@Atlassian.JIRA>
In-Reply-To: <JIRA.13075051.1495766173000@Atlassian.JIRA>
References: <JIRA.13075051.1495766173000@Atlassian.JIRA> <JIRA.13075051.1495766173629@jira-lw-us.apache.org>
Subject: [jira] [Commented] (GROOVY-8206) Groovy clone node with parent
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Fri, 26 May 2017 05:54:08 -0000


    [ https://issues.apache.org/jira/browse/GROOVY-8206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16025848#comment-16025848 ] 

Paul King commented on GROOVY-8206:
-----------------------------------

I can see what you are saying but still not sure of your full use case. What are you going to do with {{clonedNode}} after its creation? Why not just print using {{node}} as per the earlier line? Most people clone a node or node list when they plan to move/copy it into another structure. Once moved/copied the new parent value will be in place.

> Groovy clone node with parent
> -----------------------------
>
>                 Key: GROOVY-8206
>                 URL: https://issues.apache.org/jira/browse/GROOVY-8206
>             Project: Groovy
>          Issue Type: Improvement
>          Components: groovy-jdk
>            Reporter: Manish Yadav
>
> As of now groovy supports clone node feature without cloning parents.
> We can add following custom methods in some util class to make cloning more advanced :
> 1:
> {code}
> private Node cloneNode(Node node, Node parentNode) {
>     Object newValue = node.value()
>     Node clonedNode = new Node(null, node.name(), new HashMap(node.attributes()), newValue)
>     if (newValue instanceof NodeList) {
>         NodeList nodes = (NodeList) newValue
>         newValue = cloneNodeList(nodes, clonedNode)
>     }
>     clonedNode.setValue(newValue)
>     clonedNode.setParent(parentNode)
>     return clonedNode
> }
> {code}
> 2:
> {code}
> private NodeList cloneNodeList(NodeList nodeList, Node parentNode) {
>     NodeList result = new NodeList(nodeList.size())
>     for (int i = 0; i < nodeList.size(); i++) {
>         Object next = nodeList.get(i)
>         if (next instanceof Node) {
>             result.add(cloneNode((Node) next, parentNode))
>         } else {
>             result.add(next)
>         }
>     }
>     return result
> }
> {code}


--
This message was sent by Atlassian JIRA
(v6.3.15#6346)