groovy-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mnonnenmacher <...@git.apache.org>
Subject [GitHub] groovy pull request #541: Improve naming and documentation for String.tokeni...
Date Tue, 16 May 2017 16:10:59 GMT
GitHub user mnonnenmacher opened a pull request:

    https://github.com/apache/groovy/pull/541

    Improve naming and documentation for String.tokenize

    Calling the delimiter argument token is confusing as according to the
    StringTokenizer documentation delimiters are NOT treated as tokens, so call
    it delimiter instead. Also make clear that every character in the
    CharSequence argument is treated as a separate delimiter.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mnonnenmacher/groovy tokenize

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/groovy/pull/541.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #541
    
----
commit 5566d8fda1918981be582b99016c27b6bb3fb9ad
Author: Martin Nonnenmacher <martin.nonnenmacher@gmail.com>
Date:   2017-05-16T12:57:16Z

    Improve naming and documentation for String.tokenize
    
    Calling the delimiter argument token is confusing as according to the
    StringTokenizer documentation delimiters are NOT treated as tokens, so call
    it delimiter instead. Also make clear that every character in the
    CharSequence argument is treated as a separate delimiter.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message