groovy-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jwagenleitner <...@git.apache.org>
Subject [GitHub] groovy pull request #532: Prevent CachedField and CachedMethod from leaking ...
Date Wed, 17 May 2017 18:34:13 GMT
Github user jwagenleitner commented on a diff in the pull request:

    https://github.com/apache/groovy/pull/532#discussion_r117078128
  
    --- Diff: src/main/groovy/lang/MetaClassImpl.java ---
    @@ -1832,6 +1832,9 @@ public Object getProperty(Class sender, Object object, String name,
boolean useS
                 } catch (IllegalArgumentException e) {
                     // can't access the field directly but there may be a getter
                     mp = null;
    +            } catch (GroovyRuntimeException e) {
    +                // can't access the field directly but there may be a getter
    +                mp = null;
    --- End diff --
    
    I don't understand why this was added.  Was there a test that failed because of the other
changes that required this.  I would have assumed an `AccessControlException` from `CachedField.getProperty`
would be treated similar to the `IllegalAccessException` in the same method.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message