Return-Path: <notifications-return-6554-archive-asf-public=cust-asf.ponee.io@groovy.apache.org>
X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io
Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by cust-asf2.ponee.io (Postfix) with ESMTP id 352B3200BAA
	for <archive-asf-public-internal@cust-asf2.ponee.io>; Thu, 13 Oct 2016 07:09:22 +0200 (CEST)
Received: by cust-asf.ponee.io (Postfix)
	id 33ABA160AEE; Thu, 13 Oct 2016 05:09:22 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id 7A25D160ACA
	for <archive-asf-public@cust-asf.ponee.io>; Thu, 13 Oct 2016 07:09:21 +0200 (CEST)
Received: (qmail 43366 invoked by uid 500); 13 Oct 2016 05:09:20 -0000
Mailing-List: contact notifications-help@groovy.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:notifications-help@groovy.apache.org>
List-Unsubscribe: <mailto:notifications-unsubscribe@groovy.apache.org>
List-Post: <mailto:notifications@groovy.apache.org>
List-Id: <notifications.groovy.apache.org>
Reply-To: dev@groovy.apache.org
Delivered-To: mailing list notifications@groovy.apache.org
Received: (qmail 43354 invoked by uid 99); 13 Oct 2016 05:09:20 -0000
Received: from arcas.apache.org (HELO arcas) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 13 Oct 2016 05:09:20 +0000
Received: from arcas.apache.org (localhost [127.0.0.1])
	by arcas (Postfix) with ESMTP id 8D50B2C0059
	for <notifications@groovy.apache.org>; Thu, 13 Oct 2016 05:09:20 +0000 (UTC)
Date: Thu, 13 Oct 2016 05:09:20 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: notifications@groovy.apache.org
Message-ID: <JIRA.13008371.1475099883000.813277.1476335360478@Atlassian.JIRA>
In-Reply-To: <JIRA.13008371.1475099883000@Atlassian.JIRA>
References: <JIRA.13008371.1475099883000@Atlassian.JIRA> <JIRA.13008371.1475099883296@arcas>
Subject: [jira] [Commented] (GROOVY-7951)
 MethodCallExpression.transformExpression does not copy generic types
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394
archived-at: Thu, 13 Oct 2016 05:09:22 -0000


    [ https://issues.apache.org/jira/browse/GROOVY-7951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15570868#comment-15570868 ] 

ASF GitHub Bot commented on GROOVY-7951:
----------------------------------------

Github user asfgit closed the pull request at:

    https://github.com/apache/groovy/pull/441


> MethodCallExpression.transformExpression does not copy generic types
> --------------------------------------------------------------------
>
>                 Key: GROOVY-7951
>                 URL: https://issues.apache.org/jira/browse/GROOVY-7951
>             Project: Groovy
>          Issue Type: Bug
>          Components: ast builder
>    Affects Versions: 2.4.7
>            Reporter: Eric Milles
>            Priority: Minor
>
> org.codehaus.groovy.ast.expr.MethodCallExpression.transformExpression(ExpressionTransformer) is not copying generics info.  Downstream visitors are unable to check generics on static calls like Collections.<String>emptyList().
> My patched version:
> {code:java}
>     public Expression transformExpression(ExpressionTransformer transformer) {
>         MethodCallExpression answer =
>             new MethodCallExpression(transformer.transform(objectExpression), transformer.transform(method), transformer.transform(arguments));
>         answer.setSafe(safe);
>         answer.setSpreadSafe(spreadSafe);
>         answer.setImplicitThis(implicitThis);
>         // GRECLIPSE add
>         answer.setGenericsTypes(genericsTypes);
>         // GRECLIPSE end
>         answer.setMethodTarget(target);
>         answer.setSourcePosition(this);
>         answer.copyNodeMetaData(this);
>         return answer;
>     }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)