Mailing-List: contact notifications-help@groovy.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@groovy.apache.org
Date: Mon, 10 Oct 2016 10:06:20 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: notifications@groovy.apache.org
Message-ID: <JIRA.12811513.1423186486000.780801.1476093980531@Atlassian.JIRA>
In-Reply-To: <JIRA.12811513.1423186486000@Atlassian.JIRA>
References: <JIRA.12811513.1423186486000@Atlassian.JIRA> <JIRA.12811513.1423186486013@arcas>
Subject: [jira] [Commented] (GROOVY-7291) Declaration of double variable
 without value assignment referrenced in closure
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Mon, 10 Oct 2016 10:06:22 -0000


    [ https://issues.apache.org/jira/browse/GROOVY-7291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15561865#comment-15561865 ] 

ASF GitHub Bot commented on GROOVY-7291:
----------------------------------------

GitHub user blindpirate opened a pull request:

    https://github.com/apache/groovy/pull/446

    GROOVY-7291 Declaration of double variable without value assignment referrenced in closure

    According to [GROOVY-5570](https://issues.apache.org/jira/browse/GROOVY-5570), a variable referenced by closure must be non-primitive type, and it results in [GROOVY-7291](https://issues.apache.org/jira/browse/GROOVY-7291). In this case, I replace the EmptyExpression to a ConstantExpression with value 0.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/blindpirate/groovy groovy7291

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/groovy/pull/446.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #446
    
----
commit f8cb9b233ec1cfa4594f4d544ab12f9311cd4165
Author: zhangbo <zhangbo@nanchao.org>
Date:   2016-10-10T09:53:36Z

    fix groovy 7291 bug

----


> Declaration of double variable without value assignment referrenced in closure
> ------------------------------------------------------------------------------
>
>                 Key: GROOVY-7291
>                 URL: https://issues.apache.org/jira/browse/GROOVY-7291
>             Project: Groovy
>          Issue Type: Bug
>    Affects Versions: 1.8.6, 2.2.1, 2.4.0
>         Environment: Windows 8.1, JDK 1.7_71 and 1.8_25
>            Reporter: David Richter
>            Priority: Critical
>         Attachments: groovyBug.zip
>
>
> I have problem with following code:
> {code}
> double a;
> def b = {
>    a = a + 1;
> }
> b();
> {code}
> I tried to compile it with groovy 1.8.6 and it worked 
> variable 'a' was instantiated with value 0.0
> but after upgrade to groovy 2.2.1
> it throws NullPointerException because variable 'a' is instantiated to null
> I tried to decompile class files and declaration of 'a' looked like this:
> version 1.8.6
> {noformat}
> CallSite[] var1 = $getCallSiteArray();
>         final Reference a = new Reference((Double)DefaultTypeTransformation.box(0.0D));
>         DefaultTypeTransformation.doubleUnbox(a.get());
> ...
> {noformat}
> version 2.2.1
> {noformat}
> CallSite[] var1 = $getCallSiteArray();
> final Reference a = new Reference((Object)null);
> Double var10000 = (Double)a.get();
> ...
> {noformat}
> I tried it also with version 2.4.0 but it has same result as 2.2.1
> In attachment are groovy classes, compiled classes and consoleOutputs for versions 1.8.6 and 2.2.1


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)